Page MenuHomePhabricator

[CMake] Use explicit header path when using in-tree libc++ for tests
ClosedPublic

Authored by phosek on Jun 17 2022, 1:14 AM.

Details

Summary

This is a follow up to D118200 which applies a similar cleanup to
headers when using in-tree libc++ to avoid accidentally picking up
the system headers.

Diff Detail

Event Timeline

phosek created this revision.Jun 17 2022, 1:14 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 17 2022, 1:14 AM
Herald added subscribers: Enna1, mgorny. · View Herald Transcript
phosek requested review of this revision.Jun 17 2022, 1:14 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 17 2022, 1:14 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript

(Side question: What's the correct -commits list for discussing compiler-rt patches? They don't get autoassigned any, but probably should, for visibility.)

mstorsjo accepted this revision.Jun 17 2022, 1:31 AM
mstorsjo added a subscriber: libcxx-commits.

This looks reasonable to me!

This revision is now accepted and ready to land.Jun 17 2022, 1:31 AM

(Side question: What's the correct -commits list for discussing compiler-rt patches? They don't get autoassigned any, but probably should, for visibility.)

I don't see compiler-rt-commits on https://lists.llvm.org/cgi-bin/mailman/listinfo/, perhaps we could request it?

This revision was landed with ongoing or failed builds.Jul 8 2022, 8:19 PM
This revision was automatically updated to reflect the committed changes.