This is an archive of the discontinued LLVM Phabricator instance.

Differential D127933

[clang] Don't emit IFUNC when targeting Fuchsia
ClosedPublic

Authored by abrachet on Jun 15 2022, 9:22 PM.

Details

Reviewers
erichkeane
phosek
Commits
rGf4f6adc451a2: [clang] Don't emit IFUNC when targeting Fuchsia
Summary

Fuchsia's dynamic linker does not and will never support IFUNC's.

Diff Detail

Event Timeline

abrachet created this revision.Jun 15 2022, 9:22 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 15 2022, 9:22 PM
abrachet requested review of this revision.Jun 15 2022, 9:22 PM
Harbormaster completed remote builds in B170186: Diff 437438.Jun 15 2022, 10:45 PM
phosek accepted this revision.Jun 15 2022, 11:57 PM

LGTM

This revision is now accepted and ready to land.Jun 15 2022, 11:57 PM
erichkeane accepted this revision.Jun 16 2022, 6:06 AM
This revision was landed with ongoing or failed builds.Jun 16 2022, 8:38 AM
Closed by commit rGf4f6adc451a2: [clang] Don't emit IFUNC when targeting Fuchsia (authored by abrachet). · Explain Why
This revision was automatically updated to reflect the committed changes.
abrachet added a commit: rGf4f6adc451a2: [clang] Don't emit IFUNC when targeting Fuchsia.
Herald added a project: Restricted Project. · View Herald TranscriptJun 16 2022, 8:38 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
MaskRay mentioned this in rG0c3a02b8c09b: Function multi-versioning: disable ifunc for ELF targets other than….Aug 14 2023, 9:00 AM

Revision Contents

PathSize
clang/
include/
clang/
Basic/
4 lines
test/
CodeGen/
31 lines

Diff 437438

clang/include/clang/Basic/TargetInfo.h

Show First 20 Lines • Show All 1,349 Lines • ▼ Show 20 Lines virtual bool hasFeature(StringRef Feature) const {
return false; return false;
} }
/// Identify whether this target supports multiversioning of functions, /// Identify whether this target supports multiversioning of functions,
/// which requires support for cpu_supports and cpu_is functionality. /// which requires support for cpu_supports and cpu_is functionality.
bool supportsMultiVersioning() const { return getTriple().isX86(); } bool supportsMultiVersioning() const { return getTriple().isX86(); }
/// Identify whether this target supports IFuncs. /// Identify whether this target supports IFuncs.
bool supportsIFunc() const { return getTriple().isOSBinFormatELF(); } bool supportsIFunc() const {
return getTriple().isOSBinFormatELF() && !getTriple().isOSFuchsia();
}
// Validate the contents of the __builtin_cpu_supports(const char*) // Validate the contents of the __builtin_cpu_supports(const char*)
// argument. // argument.
virtual bool validateCpuSupports(StringRef Name) const { return false; } virtual bool validateCpuSupports(StringRef Name) const { return false; }
// Return the target-specific priority for features/cpus/vendors so // Return the target-specific priority for features/cpus/vendors so
// that they can be properly sorted for checking. // that they can be properly sorted for checking.
virtual unsigned multiVersionSortPriority(StringRef Name) const { virtual unsigned multiVersionSortPriority(StringRef Name) const {
▲ Show 20 Lines • Show All 307 Lines • Show Last 20 Lines

clang/test/CodeGen/attr-target-mv-va-args.c

// RUN: %clang_cc1 -no-opaque-pointers -triple x86_64-linux-gnu -emit-llvm %s -o - | FileCheck %s --check-prefix=LINUX // RUN: %clang_cc1 -no-opaque-pointers -triple x86_64-linux-gnu -emit-llvm %s -o - | FileCheck %s --check-prefix=LINUX
// RUN: %clang_cc1 -no-opaque-pointers -triple x86_64-windows-pc -emit-llvm %s -o - | FileCheck %s --check-prefix=WINDOWS // RUN: %clang_cc1 -no-opaque-pointers -triple x86_64-windows-pc -emit-llvm %s -o - | FileCheck %s --check-prefixes=NO-IFUNC,WINDOWS
// RUN: %clang_cc1 -no-opaque-pointers -triple x86_64-fuchsia -emit-llvm %s -o - | FileCheck %s --check-prefixes=NO-IFUNC,FUCHSIA
int __attribute__((target("sse4.2"))) foo(int i, ...) { return 0; } int __attribute__((target("sse4.2"))) foo(int i, ...) { return 0; }
int __attribute__((target("arch=sandybridge"))) foo(int i, ...); int __attribute__((target("arch=sandybridge"))) foo(int i, ...);
int __attribute__((target("arch=ivybridge"))) foo(int i, ...) {return 1;} int __attribute__((target("arch=ivybridge"))) foo(int i, ...) {return 1;}
int __attribute__((target("default"))) foo(int i, ...) { return 2; } int __attribute__((target("default"))) foo(int i, ...) { return 2; }
int bar(void) { int bar(void) {
return foo(1, 'a', 1.1) + foo(2, 2.2, "asdf"); return foo(1, 'a', 1.1) + foo(2, 2.2, "asdf");
} }
Show All 11 Lines
// LINUX: define weak_odr i32 (i32, ...)* @foo.resolver() comdat // LINUX: define weak_odr i32 (i32, ...)* @foo.resolver() comdat
// LINUX: ret i32 (i32, ...)* @foo.arch_sandybridge // LINUX: ret i32 (i32, ...)* @foo.arch_sandybridge
// LINUX: ret i32 (i32, ...)* @foo.arch_ivybridge // LINUX: ret i32 (i32, ...)* @foo.arch_ivybridge
// LINUX: ret i32 (i32, ...)* @foo.sse4.2 // LINUX: ret i32 (i32, ...)* @foo.sse4.2
// LINUX: ret i32 (i32, ...)* @foo // LINUX: ret i32 (i32, ...)* @foo
// LINUX: declare i32 @foo.arch_sandybridge(i32 noundef, ...) // LINUX: declare i32 @foo.arch_sandybridge(i32 noundef, ...)
// WINDOWS: define dso_local i32 @foo.sse4.2(i32 noundef %i, ...) // NO-IFUNC: define dso_local i32 @foo.sse4.2(i32 noundef %i, ...)
// WINDOWS: ret i32 0 // NO-IFUNC: ret i32 0
// WINDOWS: define dso_local i32 @foo.arch_ivybridge(i32 noundef %i, ...) // NO-IFUNC: define dso_local i32 @foo.arch_ivybridge(i32 noundef %i, ...)
// WINDOWS: ret i32 1 // NO-IFUNC: ret i32 1
// WINDOWS: define dso_local i32 @foo(i32 noundef %i, ...) // NO-IFUNC: define dso_local i32 @foo(i32 noundef %i, ...)
// WINDOWS: ret i32 2 // NO-IFUNC: ret i32 2
// WINDOWS: define dso_local i32 @bar() // NO-IFUNC: define dso_local i32 @bar()
// WINDOWS: call i32 (i32, ...) @foo.resolver(i32 noundef 1, i32 noundef 97, double // NO-IFUNC: call i32 (i32, ...) @foo.resolver(i32 noundef 1, i32 noundef 97, double
// WINDOWS: call i32 (i32, ...) @foo.resolver(i32 noundef 2, double noundef 2.2{{[0-9Ee+]+}}, i8* noundef getelementptr inbounds // NO-IFUNC: call i32 (i32, ...) @foo.resolver(i32 noundef 2, double noundef 2.2{{[0-9Ee+]+}}, i8* noundef getelementptr inbounds
// WINDOWS: define weak_odr dso_local i32 @foo.resolver(i32 %0, ...) comdat // WINDOWS: define weak_odr dso_local i32 @foo.resolver(i32 %0, ...) comdat
// WINDOWS: musttail call i32 (i32, ...) @foo.arch_sandybridge // FUCHSIA: define weak_odr i32 @foo.resolver(i32 %0, ...) comdat
// WINDOWS: musttail call i32 (i32, ...) @foo.arch_ivybridge // NO-IFUNC: musttail call i32 (i32, ...) @foo.arch_sandybridge
// WINDOWS: musttail call i32 (i32, ...) @foo.sse4.2 // NO-IFUNC: musttail call i32 (i32, ...) @foo.arch_ivybridge
// WINDOWS: musttail call i32 (i32, ...) @foo // NO-IFUNC: musttail call i32 (i32, ...) @foo.sse4.2
// NO-IFUNC: musttail call i32 (i32, ...) @foo
// WINDOWS: declare dso_local i32 @foo.arch_sandybridge(i32 noundef, ...) // WINDOWS: declare dso_local i32 @foo.arch_sandybridge(i32 noundef, ...)
// FUCHSIA: declare i32 @foo.arch_sandybridge(i32 noundef, ...)