This is an archive of the discontinued LLVM Phabricator instance.

[ORC-RT] Add integration tests for AArch64 Linux
ClosedPublic

Authored by housel on Jun 13 2022, 11:48 PM.

Details

Summary

This patch adds test cases targeting the AArch64 Linux platform to the ORC runtime.

Diff Detail

Event Timeline

housel created this revision.Jun 13 2022, 11:48 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 13 2022, 11:48 PM
housel requested review of this revision.Jun 13 2022, 11:48 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 13 2022, 11:48 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript

Wow, a lot of cool testcases.

I'm not an expert on runtime ABI, so I can't tell much. But, assembly looks fine to me.

Cheers!

lhames accepted this revision.Jun 14 2022, 2:05 PM

LGTM. Thanks @housel! Very cool to see these running out-of-the-box.

This revision is now accepted and ready to land.Jun 14 2022, 2:05 PM
This revision was landed with ongoing or failed builds.Jun 14 2022, 8:51 PM
This revision was automatically updated to reflect the committed changes.

Hi, @housel, the following error occurs when I run the test suite. I am not familiar with compiler-rt. Do you know how this problem occurs? Thank you very much if you can give me some advice!
llvm-jitlink error: Symbols not found: [ _ZTIi ]

Failed Tests (3):
  ORC-aarch64-linux :: TestCases/Linux/aarch64/ehframe-default.cpp
  ORC-aarch64-linux :: TestCases/Linux/aarch64/ehframe-libunwind.cpp
  ORC-aarch64-linux :: TestCases/Linux/aarch64/lljit-ehframe.cpp

Hi, @housel, the following error occurs when I run the test suite. I am not familiar with compiler-rt. Do you know how this problem occurs? Thank you very much if you can give me some advice!
llvm-jitlink error: Symbols not found: [ _ZTIi ]

These tests passed for me when I ran them on Debian Buster aarch64 a couple months ago. The _ZTIi symbol is the typeinfo for the int type; at least on my system this is available as a weak symbol in libstdc++. What distribution did you test? I'll rebuild and test the current main branch to verify that it still works for me.

Hi, @housel, the following error occurs when I run the test suite. I am not familiar with compiler-rt. Do you know how this problem occurs? Thank you very much if you can give me some advice!
llvm-jitlink error: Symbols not found: [ _ZTIi ]

These tests passed for me when I ran them on Debian Buster aarch64 a couple months ago. The _ZTIi symbol is the typeinfo for the int type; at least on my system this is available as a weak symbol in libstdc++. What distribution did you test? I'll rebuild and test the current main branch to verify that it still works for me.

I just ran llvm-lit and ran into this problem. I'm based on the main branch. I suspect that my running mode or running environment is faulty. Do these cases have any environment dependency? I'm currently based on the aarch64 platform

Hi, @housel, the following error occurs when I run the test suite. I am not familiar with compiler-rt. Do you know how this problem occurs? Thank you very much if you can give me some advice!
llvm-jitlink error: Symbols not found: [ _ZTIi ]

These tests passed for me when I ran them on Debian Buster aarch64 a couple months ago. The _ZTIi symbol is the typeinfo for the int type; at least on my system this is available as a weak symbol in libstdc++. What distribution did you test? I'll rebuild and test the current main branch to verify that it still works for me.

I just ran llvm-lit and ran into this problem. I'm based on the main branch. I suspect that my running mode or running environment is faulty. Do these cases have any environment dependency? I'm currently based on the aarch64 platform

Which aarch64 Linux distribution are you using? How did you configure LLVM_ENABLE_PROJECTS and LLVM_ENABLE_RUNTIMES when you configured your build?

I updated to the tip of the main branch and re-built everything, and all supported ORC tests pass for me on Debian Buster using llvm-lit.

Hi, @housel, the following error occurs when I run the test suite. I am not familiar with compiler-rt. Do you know how this problem occurs? Thank you very much if you can give me some advice!
llvm-jitlink error: Symbols not found: [ _ZTIi ]

These tests passed for me when I ran them on Debian Buster aarch64 a couple months ago. The _ZTIi symbol is the typeinfo for the int type; at least on my system this is available as a weak symbol in libstdc++. What distribution did you test? I'll rebuild and test the current main branch to verify that it still works for me.

I just ran llvm-lit and ran into this problem. I'm based on the main branch. I suspect that my running mode or running environment is faulty. Do these cases have any environment dependency? I'm currently based on the aarch64 platform

Which aarch64 Linux distribution are you using? How did you configure LLVM_ENABLE_PROJECTS and LLVM_ENABLE_RUNTIMES when you configured your build?

I updated to the tip of the main branch and re-built everything, and all supported ORC tests pass for me on Debian Buster using llvm-lit.

My env is centos-7.6 (glibc-2.17), -DLLVM_ENABLE_PROJECTS="clang;compiler-rt;libunwind;lld;openmp", use default LLVM_ENABLE_RUNTIMES. Does LLVM_ENABLE_RUNTIMES need to be set explicitly?