Page MenuHomePhabricator

housel (Peter S. Housel)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 17 2014, 4:58 PM (396 w, 4 d)

Recent Activity

Fri, May 6

housel committed rG1dda6ad80c12: [test][ORC-RT] Disable elfnix_platform tests on non-x86_64 platforms (authored by housel).
[test][ORC-RT] Disable elfnix_platform tests on non-x86_64 platforms
Fri, May 6, 8:13 PM · Restricted Project, Restricted Project
housel committed rG981523b2e467: [ORC-RT][ORC] Handle dynamic unwind registration for libunwind (authored by housel).
[ORC-RT][ORC] Handle dynamic unwind registration for libunwind
Fri, May 6, 2:01 PM · Restricted Project, Restricted Project, Restricted Project
housel closed D114961: [ORC-RT][ORC] Handle dynamic unwind registration for libunwind.
Fri, May 6, 2:01 PM · Restricted Project, Restricted Project, Restricted Project

Tue, May 3

housel updated the diff for D114961: [ORC-RT][ORC] Handle dynamic unwind registration for libunwind.

Updated in response to comments.

Tue, May 3, 10:25 PM · Restricted Project, Restricted Project, Restricted Project

Dec 2 2021

housel requested review of D114961: [ORC-RT][ORC] Handle dynamic unwind registration for libunwind.
Dec 2 2021, 7:22 AM · Restricted Project, Restricted Project, Restricted Project

Nov 18 2021

housel committed rGbab39816085d: [libunwind] Add an interface for dynamic .eh_frame registration (authored by housel).
[libunwind] Add an interface for dynamic .eh_frame registration
Nov 18 2021, 8:07 AM
housel closed D111863: [libunwind] Add an interface for dynamic .eh_frame registration.
Nov 18 2021, 8:06 AM · Restricted Project, Unknown Object (Project)

Oct 27 2021

housel updated the diff for D111863: [libunwind] Add an interface for dynamic .eh_frame registration.

Added additional comments to CFI_Parser<A>::decodeFDE.

Oct 27 2021, 7:12 PM · Restricted Project, Unknown Object (Project)

Oct 19 2021

housel added a comment to D111863: [libunwind] Add an interface for dynamic .eh_frame registration.

To be clear, this new code parses exactly as much of each FDE as the existing __register_frame/__unw_add_dynamic_fde does, including doing the same work to compute the record length. Neither needs to parse the instructions at registration time.

Oct 19 2021, 9:51 PM · Restricted Project, Unknown Object (Project)
housel added a comment to D111863: [libunwind] Add an interface for dynamic .eh_frame registration.

Are you mixing up of __register_frame and __register_frame_info?

Oct 19 2021, 9:44 AM · Restricted Project, Unknown Object (Project)

Oct 18 2021

housel added a comment to D111863: [libunwind] Add an interface for dynamic .eh_frame registration.

It's also worth noting that FreeBSD's version of libgcc exception handling is actually based on the libunwind code, with a local patch that implements compatibility with libgcc __register_frame by changing it to parse an entire .eh_frame section (in a slightly more ad hoc fashion than this code). Having this new entry point in-tree would simplify the FreeBSD local changes.

Oct 18 2021, 10:42 PM · Restricted Project, Unknown Object (Project)
housel added a comment to D111863: [libunwind] Add an interface for dynamic .eh_frame registration.

I think the ORC runtime provides a much more natural way to test this. Did you manage to come up with some ORC-runtime based tests in the end?

Oct 18 2021, 1:17 PM · Restricted Project, Unknown Object (Project)

Oct 14 2021

housel added a comment to D111863: [libunwind] Add an interface for dynamic .eh_frame registration.

I looked at the libgcc mechanism at one time. I remember that in most cases it just uses PT_GNU_EH_FRAME and these eh_frame boundary registry functions are not needed.
Can ORC just use PT_GNU_EH_FRAME?

Oct 14 2021, 10:15 PM · Restricted Project, Unknown Object (Project)
housel requested review of D111863: [libunwind] Add an interface for dynamic .eh_frame registration.
Oct 14 2021, 8:56 PM · Restricted Project, Unknown Object (Project)

Aug 15 2021

housel added a comment to D108081: [ORC] Add Platform and runtime support for ELF-based platforms.

I know that you mentioned on discord that you do not have commit access: Would you mind if I removed the walkEHFrame and TLV functions from the runtime, then committed on your behalf?

Aug 15 2021, 5:30 PM · Restricted Project, Restricted Project

Aug 14 2021

housel updated the diff for D108081: [ORC] Add Platform and runtime support for ELF-based platforms.

Corrected file header comments

Aug 14 2021, 8:56 PM · Restricted Project, Restricted Project
housel requested review of D108081: [ORC] Add Platform and runtime support for ELF-based platforms.
Aug 14 2021, 3:30 PM · Restricted Project, Restricted Project

Jul 8 2021

housel added a comment to D105389: [lldb] Add AllocateMemory/DeallocateMemory to the SBProcess API.

LGTM. Jim, chime in soon if you have any other objections!

Jul 8 2021, 10:56 AM · Restricted Project

Jul 7 2021

housel updated the diff for D105389: [lldb] Add AllocateMemory/DeallocateMemory to the SBProcess API.

Updated based on reviewer suggestions, thanks.

Jul 7 2021, 10:18 PM · Restricted Project

Jul 2 2021

housel updated the diff for D105389: [lldb] Add AllocateMemory/DeallocateMemory to the SBProcess API.
Jul 2 2021, 11:01 PM · Restricted Project
housel requested review of D105389: [lldb] Add AllocateMemory/DeallocateMemory to the SBProcess API.
Jul 2 2021, 9:23 PM · Restricted Project

Nov 26 2018

housel updated the diff for D54886: Add support for the Dylan language to ClangASTContext.

Updated against r347619

Nov 26 2018, 8:48 PM
housel added a comment to D54886: Add support for the Dylan language to ClangASTContext.

I don't have commit access; could someone land this please? Thanks.

Nov 26 2018, 8:19 PM
housel updated the diff for D54886: Add support for the Dylan language to ClangASTContext.

Adds an inline comment about Open Dylan debug info

Nov 26 2018, 8:17 PM

Nov 25 2018

housel created D54886: Add support for the Dylan language to ClangASTContext.
Nov 25 2018, 9:42 PM