This is an archive of the discontinued LLVM Phabricator instance.

[AArch64] Add cost tests for reduction add and fast fadd
ClosedPublic

Authored by virnarula on Jun 13 2022, 12:17 PM.

Details

Summary

Add test coverage showing how the costs of fadd reductions is overestimated at the moment.

Diff Detail

Event Timeline

virnarula created this revision.Jun 13 2022, 12:17 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 13 2022, 12:17 PM
virnarula requested review of this revision.Jun 13 2022, 12:17 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 13 2022, 12:17 PM

Fix costs to relfect pre-optimization numbers

virnarula edited the summary of this revision. (Show Details)Jun 13 2022, 12:38 PM
virnarula added reviewers: fhahn, anemet, thegameg.
fhahn accepted this revision.Jun 13 2022, 2:56 PM

LGTM, thanks.

As for the description, it should be sufficient to say something like Add test coverage showing how the costs of fadd reductions is overestimated at the moment.

This revision is now accepted and ready to land.Jun 13 2022, 2:56 PM
virnarula edited the summary of this revision. (Show Details)Jun 13 2022, 2:59 PM
This revision was landed with ongoing or failed builds.Jun 14 2022, 6:13 AM
This revision was automatically updated to reflect the committed changes.