Page MenuHomePhabricator

virnarula (Vir Narula )
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 2 2022, 8:16 PM (10 w, 5 d)

Recent Activity

Sun, Aug 14

virnarula added inline comments to D131125: [Matrix] Add special case dot product lowering.
Sun, Aug 14, 5:58 PM · Restricted Project, Restricted Project

Thu, Aug 11

virnarula updated the diff for D131269: [CostModel] Add bfloat and fp128 reduction tests.

Rebased onto main

Thu, Aug 11, 7:29 PM · Restricted Project, Restricted Project
virnarula updated the diff for D131444: [Matrix] Add tests dot product with varied strides.

Add comment and change test case size

Thu, Aug 11, 10:16 AM · Restricted Project, Restricted Project
virnarula added inline comments to D131125: [Matrix] Add special case dot product lowering.
Thu, Aug 11, 8:23 AM · Restricted Project, Restricted Project

Mon, Aug 8

virnarula updated the diff for D131028: [AArch64] Fix cost model for FADD vector reduction.

Use clang-format

Mon, Aug 8, 2:56 PM · Restricted Project, Restricted Project
virnarula updated the diff for D131125: [Matrix] Add special case dot product lowering.

Address first round of comments.

Mon, Aug 8, 2:38 PM · Restricted Project, Restricted Project
virnarula updated the summary of D131444: [Matrix] Add tests dot product with varied strides.
Mon, Aug 8, 2:32 PM · Restricted Project, Restricted Project
virnarula requested review of D131444: [Matrix] Add tests dot product with varied strides.
Mon, Aug 8, 2:31 PM · Restricted Project, Restricted Project

Fri, Aug 5

virnarula updated the diff for D131028: [AArch64] Fix cost model for FADD vector reduction.

Style changes and check for fp16 being enabled

Fri, Aug 5, 2:58 PM · Restricted Project, Restricted Project
virnarula updated the diff for D131028: [AArch64] Fix cost model for FADD vector reduction.

Add fp16 attribute test cases

Fri, Aug 5, 10:18 AM · Restricted Project, Restricted Project
virnarula added a reviewer for D131269: [CostModel] Add bfloat and fp128 reduction tests: fhahn.
Fri, Aug 5, 9:57 AM · Restricted Project, Restricted Project
virnarula updated the diff for D131269: [CostModel] Add bfloat and fp128 reduction tests.

Fix costs of old tests

Fri, Aug 5, 9:57 AM · Restricted Project, Restricted Project
virnarula requested review of D131269: [CostModel] Add bfloat and fp128 reduction tests.
Fri, Aug 5, 9:40 AM · Restricted Project, Restricted Project

Thu, Aug 4

virnarula updated the diff for D131028: [AArch64] Fix cost model for FADD vector reduction.

Fix order of commits for tests

Thu, Aug 4, 10:38 AM · Restricted Project, Restricted Project
virnarula added inline comments to D131028: [AArch64] Fix cost model for FADD vector reduction.
Thu, Aug 4, 10:18 AM · Restricted Project, Restricted Project

Wed, Aug 3

virnarula updated the summary of D131125: [Matrix] Add special case dot product lowering.
Wed, Aug 3, 4:03 PM · Restricted Project, Restricted Project
virnarula updated the diff for D131125: [Matrix] Add special case dot product lowering.

Fix formatting with clang-format

Wed, Aug 3, 3:53 PM · Restricted Project, Restricted Project
virnarula requested review of D131125: [Matrix] Add special case dot product lowering.
Wed, Aug 3, 3:51 PM · Restricted Project, Restricted Project
virnarula updated the diff for D131028: [AArch64] Fix cost model for FADD vector reduction.

Fix formatting

Wed, Aug 3, 1:06 PM · Restricted Project, Restricted Project
virnarula updated the diff for D131028: [AArch64] Fix cost model for FADD vector reduction.

Remove dot product test changes (will be committed alongside dot product changes).

Wed, Aug 3, 12:12 PM · Restricted Project, Restricted Project
virnarula updated the diff for D131028: [AArch64] Fix cost model for FADD vector reduction.

Fix naming and comments. Add additional test cases.

Wed, Aug 3, 11:06 AM · Restricted Project, Restricted Project

Tue, Aug 2

virnarula updated the diff for D131028: [AArch64] Fix cost model for FADD vector reduction.

Fix test files

Tue, Aug 2, 4:06 PM · Restricted Project, Restricted Project
virnarula updated the summary of D131028: [AArch64] Fix cost model for FADD vector reduction.
Tue, Aug 2, 4:01 PM · Restricted Project, Restricted Project
virnarula requested review of D131028: [AArch64] Fix cost model for FADD vector reduction.
Tue, Aug 2, 3:55 PM · Restricted Project, Restricted Project

Jul 6 2022

virnarula updated the diff for D129235: [GVN] Bug fix to reportMayClobberedLoad remark.

update test variable names

Jul 6 2022, 5:11 PM · Restricted Project, Restricted Project
virnarula updated the diff for D129235: [GVN] Bug fix to reportMayClobberedLoad remark.

Add test to patch

Jul 6 2022, 4:38 PM · Restricted Project, Restricted Project
virnarula updated the diff for D129235: [GVN] Bug fix to reportMayClobberedLoad remark.

Add testing

Jul 6 2022, 4:29 PM · Restricted Project, Restricted Project
virnarula abandoned D129238: [GVN] Add test for failing remark assertion.
Jul 6 2022, 4:24 PM · Restricted Project, Restricted Project
virnarula updated the diff for D129238: [GVN] Add test for failing remark assertion.

Add testing

Jul 6 2022, 4:09 PM · Restricted Project, Restricted Project
virnarula abandoned D129238: [GVN] Add test for failing remark assertion.
Jul 6 2022, 4:07 PM · Restricted Project, Restricted Project
virnarula requested review of D129238: [GVN] Add test for failing remark assertion.
Jul 6 2022, 4:07 PM · Restricted Project, Restricted Project
virnarula retitled D129235: [GVN] Bug fix to reportMayClobberedLoad remark from [GVN] Add bug fix to reportMayClobberedLoad remark to [GVN] Bug fix to reportMayClobberedLoad remark.
Jul 6 2022, 3:53 PM · Restricted Project, Restricted Project
virnarula requested review of D129235: [GVN] Bug fix to reportMayClobberedLoad remark.
Jul 6 2022, 3:48 PM · Restricted Project, Restricted Project

Jun 13 2022

virnarula abandoned D127548: [AArch64] Add cost tests for fast fadd reduction.

Replaced with the following review: https://reviews.llvm.org/D127682. Squashing prior to running arc diff created a new review instead of updating this one.

Jun 13 2022, 3:03 PM · Restricted Project, Restricted Project
virnarula updated the summary of D127682: [AArch64] Add cost tests for reduction add and fast fadd.
Jun 13 2022, 2:59 PM · Restricted Project, Restricted Project
virnarula updated the summary of D127682: [AArch64] Add cost tests for reduction add and fast fadd.
Jun 13 2022, 12:38 PM · Restricted Project, Restricted Project
virnarula updated the diff for D127682: [AArch64] Add cost tests for reduction add and fast fadd.

Fix costs to relfect pre-optimization numbers

Jun 13 2022, 12:37 PM · Restricted Project, Restricted Project
virnarula requested review of D127682: [AArch64] Add cost tests for reduction add and fast fadd.
Jun 13 2022, 12:17 PM · Restricted Project, Restricted Project
virnarula retitled D127548: [AArch64] Add cost tests for fast fadd reduction from [Matrix] Add cost tests for fast fadd reduction to [AArch64] Add cost tests for fast fadd reduction.
Jun 13 2022, 9:41 AM · Restricted Project, Restricted Project

Jun 10 2022

virnarula retitled D127548: [AArch64] Add cost tests for fast fadd reduction from [Matrix] Add cost tests for reduction add and fast fadd to [Matrix] Add cost tests for fast fadd reduction.
Jun 10 2022, 3:57 PM · Restricted Project, Restricted Project
virnarula requested review of D127548: [AArch64] Add cost tests for fast fadd reduction.
Jun 10 2022, 3:54 PM · Restricted Project, Restricted Project

Jun 3 2022

virnarula updated the diff for D126942: [LowerMatrixIntrinsics] Add dot product tests.

Adding tests for smaller dimensions

Jun 3 2022, 9:59 AM · Restricted Project, Restricted Project
virnarula retitled D126942: [LowerMatrixIntrinsics] Add dot product tests from [llvm-lib] Add dot product tests to [LowerMatrixIntrinsics] Add dot product tests.
Jun 3 2022, 9:02 AM · Restricted Project, Restricted Project

Jun 2 2022

virnarula updated the summary of D126942: [LowerMatrixIntrinsics] Add dot product tests.
Jun 2 2022, 9:09 PM · Restricted Project, Restricted Project
virnarula requested review of D126942: [LowerMatrixIntrinsics] Add dot product tests.
Jun 2 2022, 9:03 PM · Restricted Project, Restricted Project