This is an archive of the discontinued LLVM Phabricator instance.

Differential D127656

[llvm-cxxfilt] Add description for --types in help text
ClosedPublic

Authored by gbreynoo on Jun 13 2022, 8:34 AM.

Details

Reviewers
MaskRay
jhenderson
Commits
rGc4a35c78aab2: [llvm-cxxfilt] Add description for --types in help text
Summary

It appears that in the move to tablegen the description of --types was lost:
https://reviews.llvm.org/D105605

This change adds the missing description.

Diff Detail

Event Timeline

gbreynoo created this revision.Jun 13 2022, 8:34 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 13 2022, 8:34 AM
Herald added a subscriber: StephenFan. · View Herald Transcript
gbreynoo requested review of this revision.Jun 13 2022, 8:34 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 13 2022, 8:34 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Harbormaster completed remote builds in B169467: Diff 436410.Jun 13 2022, 10:10 AM
MaskRay accepted this revision.Jun 13 2022, 11:06 AM

Thanks for catching this

This revision is now accepted and ready to land.Jun 13 2022, 11:06 AM
This revision was landed with ongoing or failed builds.Jun 14 2022, 2:34 AM
Closed by commit rGc4a35c78aab2: [llvm-cxxfilt] Add description for --types in help text (authored by gbreynoo). · Explain Why
This revision was automatically updated to reflect the committed changes.
gbreynoo added a commit: rGc4a35c78aab2: [llvm-cxxfilt] Add description for --types in help text.

Revision Contents

PathSize
llvm/
tools/
llvm-cxxfilt/
2 lines

Diff 436410

llvm/tools/llvm-cxxfilt/Opts.td

Show All 10 Lines
multiclass Eq<string name, string help> { multiclass Eq<string name, string help> {
def NAME #_EQ : Joined<["--"], name #"=">, def NAME #_EQ : Joined<["--"], name #"=">,
HelpText<help>; HelpText<help>;
def : Separate<["--"], name>, Alias<!cast<Joined>(NAME #_EQ)>; def : Separate<["--"], name>, Alias<!cast<Joined>(NAME #_EQ)>;
} }
def help : FF<"help", "Display this help">; def help : FF<"help", "Display this help">;
defm strip_underscore : BB<"strip-underscore", "Strip the leading underscore", "Don't strip the leading underscore">; defm strip_underscore : BB<"strip-underscore", "Strip the leading underscore", "Don't strip the leading underscore">;
def types : FF<"types", "">; def types : FF<"types", "Attempt to demangle types as well as function names">;
def version : FF<"version", "Display the version">; def version : FF<"version", "Display the version">;
defm : Eq<"format", "Specify mangling format. Currently ignored because only 'gnu' is supported">; defm : Eq<"format", "Specify mangling format. Currently ignored because only 'gnu' is supported">;
def : F<"s", "Alias for --format">; def : F<"s", "Alias for --format">;
def : F<"_", "Alias for --strip-underscore">, Alias<strip_underscore>; def : F<"_", "Alias for --strip-underscore">, Alias<strip_underscore>;
def : F<"h", "Alias for --help">, Alias<help>; def : F<"h", "Alias for --help">, Alias<help>;
def : F<"n", "Alias for --no-strip-underscore">, Alias<no_strip_underscore>; def : F<"n", "Alias for --no-strip-underscore">, Alias<no_strip_underscore>;
def : F<"t", "Alias for --types">, Alias<types>; def : F<"t", "Alias for --types">, Alias<types>;