This is an archive of the discontinued LLVM Phabricator instance.

[libc++] Granularize some more of <type_traits>
ClosedPublic

Authored by philnik on Jun 13 2022, 4:50 AM.

Details

Diff Detail

Event Timeline

philnik created this revision.Jun 13 2022, 4:50 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 13 2022, 4:50 AM
Herald added a subscriber: mgorny. · View Herald Transcript
philnik requested review of this revision.Jun 13 2022, 4:50 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 13 2022, 4:50 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
ldionne accepted this revision.Jun 13 2022, 7:45 AM

I'm fine with this, but I'd like to record that the benefit of splitting small quasi-one-liners into a separate file is limited. I think it's fine for consistency, but if we end up using intrinsics for almost all of the type traits, it may make sense to group them into slightly larger headers, because the boilerplate of a header for 4-5 lines of content is not really worth it.

But like I said, this is consistent with the rest of the code so let's go ahead.

This revision is now accepted and ready to land.Jun 13 2022, 7:45 AM
philnik updated this revision to Diff 436417.Jun 13 2022, 8:37 AM
  • Try to fix CI
This revision was landed with ongoing or failed builds.Jun 13 2022, 12:37 PM
This revision was automatically updated to reflect the committed changes.