This is an archive of the discontinued LLVM Phabricator instance.

Differential D127592

[libc++] Removes unneeded includes.
ClosedPublic

Authored by Mordante on Jun 12 2022, 3:05 AM.

Details

Reviewers
ldionne
Group Reviewers
Restricted Project
Commits
rGc36870c8e79c: [libc++] Removes unneeded includes.
Summary

This removes all "TODO: remove these headers" comments from our headers.

Note there seem to be more headers that can be removed, that will be
done in separate commits.

Diff Detail

Unit TestsFailed

TimeTest
1,020 mslibcxx CI Modular build > llvm-libc++-shared-cfg-in.std/ranges/range_adaptors/range_join_view::adaptor.pass.cpp
640 mslibcxx CI Modular build > llvm-libc++-shared-cfg-in.std/ranges/range_adaptors/range_join_view::base.pass.cpp
970 mslibcxx CI Modular build > llvm-libc++-shared-cfg-in.std/ranges/range_adaptors/range_join_view::begin.pass.cpp
570 mslibcxx CI Modular build > llvm-libc++-shared-cfg-in.std/ranges/range_adaptors/range_join_view::ctor.default.pass.cpp
620 mslibcxx CI Modular build > llvm-libc++-shared-cfg-in.std/ranges/range_adaptors/range_join_view::ctor.view.pass.cpp
View Full Test Results (21 Failed)

Event Timeline

Mordante created this revision.Jun 12 2022, 3:05 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 12 2022, 3:05 AM
Herald added a subscriber: arphaman. · View Herald Transcript
Mordante requested review of this revision.Jun 12 2022, 3:05 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 12 2022, 3:05 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: libcxx-commits. · View Herald Transcript
philnik added a subscriber: philnik.Jun 12 2022, 3:07 AM

While you're at it you can also remove all the #include <iterator> // TODO: Remove this include.

Mordante added a comment.Jun 12 2022, 3:31 AM
In D127592#3576162, @philnik wrote:

While you're at it you can also remove all the #include <iterator> // TODO: Remove this include.

As mentioned in the commit message I want to do more cleanups in separate commits.
The iterator is indeed on my TODO list for a separate patch.

Harbormaster completed remote builds in B169296: Diff 436203.Jun 12 2022, 3:50 AM
Mordante updated this revision to Diff 436213.Jun 12 2022, 6:26 AM

Adds missing includes in the tests.

Harbormaster completed remote builds in B169306: Diff 436213.Jun 12 2022, 7:31 AM
ldionne accepted this revision.Jun 13 2022, 7:39 AM
This revision is now accepted and ready to land.Jun 13 2022, 7:39 AM
This revision was landed with ongoing or failed builds.Jun 13 2022, 8:57 AM
Closed by commit rGc36870c8e79c: [libc++] Removes unneeded includes. (authored by Mordante). · Explain Why
This revision was automatically updated to reflect the committed changes.
Mordante added a commit: rGc36870c8e79c: [libc++] Removes unneeded includes..

Revision Contents

PathSize
libcxx/
docs/
3 lines
include/
7 lines
5 lines
4 lines
5 lines
5 lines
5 lines
3 lines

Diff 436203

libcxx/docs/ReleaseNotes.rst

Show First 20 Lines • Show All 91 Lines • ▼ Show 20 Lines
- The header ``<experimental/filesystem>`` has been removed. Instead, use - The header ``<experimental/filesystem>`` has been removed. Instead, use
``<filesystem>`` header. The associated macro ``<filesystem>`` header. The associated macro
``_LIBCPP_DEPRECATED_EXPERIMENTAL_FILESYSTEM`` has also been removed. ``_LIBCPP_DEPRECATED_EXPERIMENTAL_FILESYSTEM`` has also been removed.
- Some libc++ headers no longer transitively include all of: - Some libc++ headers no longer transitively include all of:
- ``<algorithm>`` - ``<algorithm>``
- ``<chrono>`` - ``<chrono>``
- ``<exception>``
- ``<functional>`` - ``<functional>``
- ``<new>``
- ``<typeinfo>``
- ``<utility>`` - ``<utility>``
If, after updating libc++, you see compiler errors related to missing declarations If, after updating libc++, you see compiler errors related to missing declarations
in namespace ``std``, it might be because one of your source files now needs to in namespace ``std``, it might be because one of your source files now needs to
include one or more of the headers listed above. include one or more of the headers listed above.
- The integer distributions ``binomial_distribution``, ``discrete_distribution``, - The integer distributions ``binomial_distribution``, ``discrete_distribution``,
``geometric_distribution``, ``negative_binomial_distribution``, ``poisson_distribution``, ``geometric_distribution``, ``negative_binomial_distribution``, ``poisson_distribution``,
▲ Show 20 Lines • Show All 91 Lines • Show Last 20 Lines

libcxx/include/iterator

Show First 20 Lines • Show All 717 Lines • ▼ Show 20 Lines
#include <__memory/pointer_traits.h> #include <__memory/pointer_traits.h>
#include <compare> #include <compare>
#include <concepts> // Mandated by the Standard. #include <concepts> // Mandated by the Standard.
#include <cstddef> #include <cstddef>
#include <initializer_list> #include <initializer_list>
#include <type_traits> #include <type_traits>
#include <version> #include <version>
// TODO: remove these headers
#include <__memory/allocator_arg_t.h>
#include <__memory/uses_allocator.h>
#include <exception>
#include <new>
#include <typeinfo>
#if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER) #if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER)
# pragma GCC system_header # pragma GCC system_header
#endif #endif
#endif // _LIBCPP_ITERATOR #endif // _LIBCPP_ITERATOR

libcxx/include/optional

Show First 20 Lines • Show All 172 Lines • ▼ Show 20 Lines
#include <__utility/swap.h> #include <__utility/swap.h>
#include <compare> #include <compare>
#include <initializer_list> #include <initializer_list>
#include <new> #include <new>
#include <stdexcept> #include <stdexcept>
#include <type_traits> #include <type_traits>
#include <version> #include <version>
// TODO: remove these headers
#include <__memory/allocator_arg_t.h>
#include <__memory/uses_allocator.h>
#include <typeinfo>
#if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER) #if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER)
# pragma GCC system_header # pragma GCC system_header
#endif #endif
namespace std // purposefully not using versioning namespace namespace std // purposefully not using versioning namespace
{ {
class _LIBCPP_EXCEPTION_ABI _LIBCPP_AVAILABILITY_BAD_OPTIONAL_ACCESS bad_optional_access class _LIBCPP_EXCEPTION_ABI _LIBCPP_AVAILABILITY_BAD_OPTIONAL_ACCESS bad_optional_access
▲ Show 20 Lines • Show All 1,385 Lines • Show Last 20 Lines

libcxx/include/string

Show First 20 Lines • Show All 547 Lines • ▼ Show 20 Lines
#include <iterator> // TODO: Remove this include #include <iterator> // TODO: Remove this include
#include <limits> #include <limits>
#include <memory> #include <memory>
#include <stdexcept> #include <stdexcept>
#include <string_view> #include <string_view>
#include <type_traits> #include <type_traits>
#include <version> #include <version>
// TODO: remove these headers
#include <new>
#include <typeinfo>
#ifndef _LIBCPP_HAS_NO_WIDE_CHARACTERS #ifndef _LIBCPP_HAS_NO_WIDE_CHARACTERS
# include <cwchar> # include <cwchar>
#endif #endif
#ifndef _LIBCPP_HAS_NO_UNICODE_CHARS #ifndef _LIBCPP_HAS_NO_UNICODE_CHARS
# include <cstdint> # include <cstdint>
#endif #endif
▲ Show 20 Lines • Show All 4,132 Lines • Show Last 20 Lines

libcxx/include/tuple

Show First 20 Lines • Show All 178 Lines • ▼ Show 20 Lines
#include <__utility/pair.h> #include <__utility/pair.h>
#include <__utility/piecewise_construct.h> #include <__utility/piecewise_construct.h>
#include <__utility/swap.h> #include <__utility/swap.h>
#include <compare> #include <compare>
#include <cstddef> #include <cstddef>
#include <type_traits> #include <type_traits>
#include <version> #include <version>
// TODO: remove these headers
#include <exception>
#include <new>
#include <typeinfo>
#if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER) #if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER)
# pragma GCC system_header # pragma GCC system_header
#endif #endif
_LIBCPP_BEGIN_NAMESPACE_STD _LIBCPP_BEGIN_NAMESPACE_STD
#ifndef _LIBCPP_CXX03_LANG #ifndef _LIBCPP_CXX03_LANG
▲ Show 20 Lines • Show All 1,444 Lines • Show Last 20 Lines

libcxx/include/typeindex

Show First 20 Lines • Show All 45 Lines • ▼ Show 20 Lines
#include <__assert> // all public C++ headers provide the assertion handler #include <__assert> // all public C++ headers provide the assertion handler
#include <__config> #include <__config>
#include <__functional/unary_function.h> #include <__functional/unary_function.h>
#include <compare> #include <compare>
#include <typeinfo> #include <typeinfo>
#include <version> #include <version>
// TODO: remove these headers
#include <__memory/allocator_arg_t.h>
#include <__memory/uses_allocator.h>
#include <new>
#if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER) #if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER)
# pragma GCC system_header # pragma GCC system_header
#endif #endif
_LIBCPP_BEGIN_NAMESPACE_STD _LIBCPP_BEGIN_NAMESPACE_STD
class _LIBCPP_TEMPLATE_VIS type_index class _LIBCPP_TEMPLATE_VIS type_index
{ {
▲ Show 20 Lines • Show All 44 Lines • Show Last 20 Lines

libcxx/include/variant

Show First 20 Lines • Show All 214 Lines • ▼ Show 20 Lines
#include <exception> #include <exception>
#include <initializer_list> #include <initializer_list>
#include <limits> #include <limits>
#include <new> #include <new>
#include <tuple> #include <tuple>
#include <type_traits> #include <type_traits>
#include <version> #include <version>
// TODO: remove these headers
#include <__memory/allocator_arg_t.h>
#include <__memory/uses_allocator.h>
#include <typeinfo>
#if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER) #if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER)
# pragma GCC system_header # pragma GCC system_header
#endif #endif
_LIBCPP_PUSH_MACROS _LIBCPP_PUSH_MACROS
#include <__undef_macros> #include <__undef_macros>
namespace std { // explicitly not using versioning namespace namespace std { // explicitly not using versioning namespace
▲ Show 20 Lines • Show All 1,553 Lines • Show Last 20 Lines

libcxx/include/vector

Show First 20 Lines • Show All 301 Lines • ▼ Show 20 Lines
#include <initializer_list> #include <initializer_list>
#include <iosfwd> // for forward declaration of vector #include <iosfwd> // for forward declaration of vector
#include <limits> #include <limits>
#include <memory> #include <memory>
#include <stdexcept> #include <stdexcept>
#include <type_traits> #include <type_traits>
#include <version> #include <version>
// TODO: remove these headers
#include <typeinfo>
#if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER) #if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER)
# pragma GCC system_header # pragma GCC system_header
#endif #endif
_LIBCPP_PUSH_MACROS _LIBCPP_PUSH_MACROS
#include <__undef_macros> #include <__undef_macros>
▲ Show 20 Lines • Show All 2,909 Lines • Show Last 20 Lines