This is an archive of the discontinued LLVM Phabricator instance.

[libc++] Removes unneeded includes.
ClosedPublic

Authored by Mordante on Jun 12 2022, 3:05 AM.

Details

Reviewers
ldionne
Group Reviewers
Restricted Project
Commits
rGc36870c8e79c: [libc++] Removes unneeded includes.
Summary

This removes all "TODO: remove these headers" comments from our headers.

Note there seem to be more headers that can be removed, that will be
done in separate commits.

Diff Detail

Event Timeline

Mordante created this revision.Jun 12 2022, 3:05 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 12 2022, 3:05 AM
Herald added a subscriber: arphaman. · View Herald Transcript
Mordante requested review of this revision.Jun 12 2022, 3:05 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 12 2022, 3:05 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript

While you're at it you can also remove all the #include <iterator> // TODO: Remove this include.

While you're at it you can also remove all the #include <iterator> // TODO: Remove this include.

As mentioned in the commit message I want to do more cleanups in separate commits.
The iterator is indeed on my TODO list for a separate patch.

Mordante updated this revision to Diff 436213.Jun 12 2022, 6:26 AM

Adds missing includes in the tests.

ldionne accepted this revision.Jun 13 2022, 7:39 AM
This revision is now accepted and ready to land.Jun 13 2022, 7:39 AM
This revision was landed with ongoing or failed builds.Jun 13 2022, 8:57 AM
This revision was automatically updated to reflect the committed changes.