This is an archive of the discontinued LLVM Phabricator instance.

Differential D127498

[SystemZ/z/OS] Set DWARF version to 4 for z/OS.
ClosedPublic

Authored by Kai on Jun 10 2022, 7:24 AM.

Details

Reviewers
uweigand
• jnspaulsson
abhina.sreeskantharajan
yusra.syeda
Commits
rGb5019ffc8efd: [SystemZ/z/OS] Set DWARF version to 4 for z/OS.
Summary

The DWARF version was raised to 5 for all platforms which do not opt
out. Default to DWARF version to 4 for z/OS again.

Diff Detail

Event Timeline

Kai created this revision.Jun 10 2022, 7:24 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 10 2022, 7:24 AM
Kai requested review of this revision.Jun 10 2022, 7:24 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 10 2022, 7:24 AM
Herald added subscribers: cfe-commits, MaskRay. · View Herald Transcript
abhina.sreeskantharajan accepted this revision.Jun 10 2022, 7:33 AM

LGTM

This revision is now accepted and ready to land.Jun 10 2022, 7:33 AM
Harbormaster completed remote builds in B169069: Diff 435909.Jun 10 2022, 8:31 AM
uweigand accepted this revision.Jun 10 2022, 8:51 AM

LGTM

Closed by commit rGb5019ffc8efd: [SystemZ/z/OS] Set DWARF version to 4 for z/OS. (authored by Kai). · Explain WhyJun 10 2022, 10:39 AM
This revision was automatically updated to reflect the committed changes.
Kai added a commit: rGb5019ffc8efd: [SystemZ/z/OS] Set DWARF version to 4 for z/OS..

Revision Contents

PathSize
clang/
lib/
Driver/
ToolChains/
2 lines
test/
Driver/
3 lines

Diff 435970

clang/lib/Driver/ToolChains/ZOS.h

Show All 24 Linespublic:
bool isPICDefault() const override { return false; } bool isPICDefault() const override { return false; }
bool isPIEDefault(const llvm::opt::ArgList &Args) const override { bool isPIEDefault(const llvm::opt::ArgList &Args) const override {
return false; return false;
} }
bool isPICDefaultForced() const override { return false; } bool isPICDefaultForced() const override { return false; }
bool IsIntegratedAssemblerDefault() const override { return true; } bool IsIntegratedAssemblerDefault() const override { return true; }
unsigned GetDefaultDwarfVersion() const override { return 4; }
void addClangTargetOptions( void addClangTargetOptions(
const llvm::opt::ArgList &DriverArgs, llvm::opt::ArgStringList &CC1Args, const llvm::opt::ArgList &DriverArgs, llvm::opt::ArgStringList &CC1Args,
Action::OffloadKind DeviceOffloadingKind) const override; Action::OffloadKind DeviceOffloadingKind) const override;
}; };
} // end namespace toolchains } // end namespace toolchains
} // end namespace driver } // end namespace driver
} // end namespace clang } // end namespace clang
#endif // LLVM_CLANG_LIB_DRIVER_TOOLCHAINS_ZOS_H #endif // LLVM_CLANG_LIB_DRIVER_TOOLCHAINS_ZOS_H

clang/test/Driver/zos-dwarfversion.c

  • This file was added.
// RUN: %clang -target s390x-none-zos -g -S -emit-llvm %s -o - | FileCheck %s
// CHECK: !"Dwarf Version", i32 4