This is an archive of the discontinued LLVM Phabricator instance.

[libc++] Implement P0174R2 (Deprecating Vestigial Library Parts in C++17)
ClosedPublic

Authored by philnik on Jun 9 2022, 3:09 AM.

Diff Detail

Event Timeline

philnik created this revision.Jun 9 2022, 3:09 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 9 2022, 3:09 AM
philnik requested review of this revision.Jun 9 2022, 3:09 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 9 2022, 3:09 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
ldionne accepted this revision.Jun 10 2022, 8:25 AM
ldionne added a subscriber: jwakely.

LGTM without the allocator<void> part (and with passing CI).

libcxx/include/__memory/allocator.h
34

There's a bit of history behind this, but TLDR, I don't think we want to do this part: https://reviews.llvm.org/D104323.

In particular, I think reading https://github.com/llvm/llvm-project/issues/49643 by @jwakely is relevant.

This revision is now accepted and ready to land.Jun 10 2022, 8:25 AM
Mordante added inline comments.Jun 11 2022, 11:53 AM
libcxx/include/__memory/allocator.h
34

Can you add some comment why this is intended not to be deprecated.
That way we can avoid a third deprecation round.

philnik updated this revision to Diff 437096.Jun 15 2022, 2:56 AM
philnik marked 2 inline comments as done.
  • [libc++] Try to fix CI
philnik updated this revision to Diff 437122.Jun 15 2022, 5:56 AM
  • next try
Mordante accepted this revision.Jun 15 2022, 9:47 AM

LGTM modulo one nit and when the CI is happy.

libcxx/test/std/utilities/memory/temporary.buffer/depr.verify.cpp
11
philnik updated this revision to Diff 437487.Jun 16 2022, 2:48 AM
  • Try to fix CI