This is an archive of the discontinued LLVM Phabricator instance.

Differential D127327

[MSAN] Add comment regarding why pthread_getaffinity_np is not supported on Android.
ClosedPublic

Authored by kda on Jun 8 2022, 11:26 AM.

Download Raw Diff

Details

Reviewers

vitalybuka
fmayer

Commits

rGd50dc33d29dd: [MSAN] Add comment regarding why pthread_getaffinity_np is not supported on…

Summary

Depends on: https://reviews.llvm.org/D127264

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

kda created this revision.Jun 8 2022, 11:26 AM

Herald added a project: Restricted Project. · View Herald TranscriptJun 8 2022, 11:26 AM

Herald added subscribers: Enna1, danielkiss. · View Herald Transcript

kda requested review of this revision.Jun 8 2022, 11:26 AM

Herald added a project: Restricted Project. · View Herald TranscriptJun 8 2022, 11:26 AM

Herald added a subscriber: Restricted Project. · View Herald Transcript

fmayer accepted this revision.Jun 8 2022, 11:31 AM

fmayer added a subscriber: fmayer.

fmayer added inline comments.

compiler-rt/test/sanitizer_common/TestCases/Linux/pthread_getaffinity_np.cpp
4	random driveby: this means Bionic libc, right?

This revision is now accepted and ready to land.Jun 8 2022, 11:31 AM

Harbormaster completed remote builds in B168638: Diff 435266.Jun 8 2022, 12:41 PM

vitalybuka accepted this revision.Jun 8 2022, 1:51 PM

kda added inline comments.Jun 8 2022, 1:53 PM

compiler-rt/test/sanitizer_common/TestCases/Linux/pthread_getaffinity_np.cpp
4	No idea. eugenis@ mentioned this: https://reviews.llvm.org/D127145

Closed by commit rGd50dc33d29dd: [MSAN] Add comment regarding why pthread_getaffinity_np is not supported on… (authored by kda). · Explain WhyJun 8 2022, 1:54 PM

This revision was automatically updated to reflect the committed changes.

kda added a commit: rGd50dc33d29dd: [MSAN] Add comment regarding why pthread_getaffinity_np is not supported on….

I believe "Depends on" should be in the summary, no in the title

moved Depends on.

kda mentioned this in D127364: [MSAN] mark test as unsupported for powerpc..Jun 8 2022, 5:06 PM

Revision Contents

Path

Size

compiler-rt/

test/

sanitizer_common/

TestCases/

Linux/

pthread_getaffinity_np.cpp

3 lines

Diff 435317

compiler-rt/test/sanitizer_common/TestCases/Linux/pthread_getaffinity_np.cpp

	// RUN: %clangxx -O0 %s -o %t && %run %t			// RUN: %clangxx -O0 %s -o %t && %run %t

				// Android does not implement pthread_getaffinity_np.
				// (Note: libresolv is integrated with libc, but apparently only
				fmayerUnsubmitted Not Done Reply Inline Actions random driveby: this means Bionic libc, right? fmayer: random driveby: this means Bionic libc, right?
				kdaAuthorUnsubmitted Done Reply Inline Actions No idea. eugenis@ mentioned this: https://reviews.llvm.org/D127145 kda: No idea. eugenis@ mentioned this: https://reviews.llvm.org/D127145
				// sched_getaffinity).
	// UNSUPPORTED: android			// UNSUPPORTED: android

	#include <assert.h>			#include <assert.h>
	#include <pthread.h>			#include <pthread.h>
	#include <stdio.h>			#include <stdio.h>
	#include <sys/sysinfo.h>			#include <sys/sysinfo.h>

	#include <sanitizer/msan_interface.h>			#include <sanitizer/msan_interface.h>
	Show All 11 Lines