This is an archive of the discontinued LLVM Phabricator instance.

[scan-build-py] Fix exception on shutdown with sarif-html output format
ClosedPublic

Authored by wanders on Jun 3 2022, 10:02 AM.

Details

Summary

When running scan-build-py's analyze-build script with output format set
to sarif & html it wants to print a message on how to look at the
defects mentioning the directory name twice.

But the path argument was only given once to the logging function,
causing "TypeError: not enough arguments for format string" exception.

Diff Detail

Event Timeline

wanders created this revision.Jun 3 2022, 10:02 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 3 2022, 10:02 AM
Herald added a subscriber: whisperity. · View Herald Transcript
wanders requested review of this revision.Jun 3 2022, 10:02 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 3 2022, 10:02 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript

Gentle 1-week ping

This revision is now accepted and ready to land.Jun 10 2022, 10:45 AM

Would it be possible to reupload the diff with full context?

wanders updated this revision to Diff 435999.Jun 10 2022, 11:59 AM

Updated patch with full context.

phosek accepted this revision.Jun 10 2022, 12:09 PM

LGTM