This is an archive of the discontinued LLVM Phabricator instance.

[BOLT][NFC] Pass Function to BC.printInstructions in BinaryBasicBlock::dump
ClosedPublic

Authored by Amir on Jun 2 2022, 1:36 PM.

Details

Summary

BC::printInstruction(s) has many uses of Function ptr if it's available:

  1. printing CFI instructions (unconditional)
  2. printing debug line information (-print-debug-info)
  3. printing instruction relocations (-print-relocations)

Enable these uses by passing Function ptr from the primary printing entry point:
BinaryBasicBlock::dump.

Diff Detail

Event Timeline

Amir created this revision.Jun 2 2022, 1:36 PM
Herald added a reviewer: maksfb. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
Herald added a subscriber: ayermolo. · View Herald Transcript
Amir requested review of this revision.Jun 2 2022, 1:36 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 2 2022, 1:36 PM
maksfb accepted this revision.Jun 2 2022, 2:41 PM

LGTM

This revision is now accepted and ready to land.Jun 2 2022, 2:41 PM