This is an archive of the discontinued LLVM Phabricator instance.

[clang] [Headers] Check __SEH__, when checking if ARM EHABI is implied
ClosedPublic

Authored by mstorsjo on Jun 2 2022, 2:34 AM.

Details

Summary

ARM EHABI isn't signalled by any specific compiler builtin define,
but is implied by the lack of defines specifying any other
exception handling mechanism, __USING_SJLJ_EXCEPTIONS__ or
__ARM_DWARF_EH__.

As Windows SEH also can be used for unwinding, check for the
__SEH__ define too, in the same way.

Diff Detail

Event Timeline

mstorsjo created this revision.Jun 2 2022, 2:34 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 2 2022, 2:34 AM
mstorsjo requested review of this revision.Jun 2 2022, 2:34 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 2 2022, 2:34 AM

@MaskRay Thanks for the other reviews! This one is the last one with the same condition added.

MaskRay accepted this revision.Jun 5 2022, 12:52 PM

LGTM

This revision is now accepted and ready to land.Jun 5 2022, 12:52 PM
This revision was landed with ongoing or failed builds.Jun 6 2022, 1:28 PM
This revision was automatically updated to reflect the committed changes.