string_view is supported all the way back to C++03 as an extension in
libc++, and so many of the tests run in all standards modes for all vendors.
This is unlikely desired by other standard library vendors using our test suite.
So, disable the tests for vendors other than libc++ in these older standards
modes.
Details
- Reviewers
ldionne var-const Mordante philnik - Group Reviewers
Restricted Project - Commits
- rG4fc502368ad0: [libc++][test] Skip string_view tests for other vendors on older modes
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Thanks for the cleanup! There are several minor issues.
libcxx/test/std/strings/string.view/string.view.cons/from_iterator_sentinel.pass.cpp | ||
---|---|---|
15 ↗ | (On Diff #433637) | This isn't needed, see line 8. |
libcxx/test/std/strings/string.view/string.view.cons/from_range.pass.cpp | ||
16 ↗ | (On Diff #433637) | This isn't needed, see line 8. |
libcxx/test/std/strings/string.view/string.view.hash/string_view.pass.cpp | ||
20 | Can you move this more to the top, (before // <functional>) of the file like we do in the other tests? Same for other places. | |
libcxx/test/std/strings/string.view/string.view.template/ends_with.ptr.pass.cpp | ||
31 ↗ | (On Diff #433637) | Is this intended? It adds new unused variables. (This file contains a similar commented out block at line 71.) The same for the next file. |
libcxx/test/std/strings/string.view/string.view.hash/string_view.pass.cpp | ||
---|---|---|
20 | Done! Good spot. | |
libcxx/test/std/strings/string.view/string.view.template/ends_with.ptr.pass.cpp | ||
31 ↗ | (On Diff #433637) | Sorry, this was done in a separate PR (https://github.com/llvm/llvm-project/commit/6423a9f0ec8ba70049ea76e7bcfc9a9d1a54e826) and was wrong to begin with. It is fixed with https://reviews.llvm.org/D126901 |
There are a few places where the UNSUPPORTED isn't in the proper spot, I've marked all of them. Please update these before landing this patch.
Other than these nits, LGTM.
libcxx/test/std/strings/string.view/char.bad.fail.cpp | ||
---|---|---|
14 | Please move up. | |
libcxx/test/std/strings/string.view/string.view.access/front.pass.cpp | ||
15 | Please move up. | |
libcxx/test/std/strings/string.view/string.view.find/find_last_not_of_string_view_size.pass.cpp | ||
15 | Please move up. |
Please move up.