This is an archive of the discontinued LLVM Phabricator instance.

[scan-build-py] Change scripts to explicitly require python3
ClosedPublic

Authored by wanders on Jun 1 2022, 11:59 AM.

Details

Summary

The "#!" line in all scan-build-py scripts were using just bare
"/usr/bin/python" which according to PEP-0394 can be either python3,
python2 or not exist at all.

E.g in latest debian and ubuntu releases "/usr/bin/python" does not
exist at all by default and user must install python-is-python2 or
python-is-python3 packages to get the bare version less "python"
command.

Until recently (70b06fe8a186 "scan-build-py: Force the opening in utf-8"
changed "libscanbuild") these scripts worked in both python2 and
python3, but now they (rightfully) are python3 only, and broke on
systems where the "python" command means python2.

By changing the "#!" to be "python3" it is not only explicit that the
scripts require python3 it also works on systems where "python" command
is python2 or nonexistent.

Diff Detail

Event Timeline

wanders created this revision.Jun 1 2022, 11:59 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 1 2022, 11:59 AM
Herald added a subscriber: whisperity. · View Herald Transcript
wanders requested review of this revision.Jun 1 2022, 11:59 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 1 2022, 11:59 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
phosek accepted this revision.Jun 1 2022, 1:31 PM

LGTM

This revision is now accepted and ready to land.Jun 1 2022, 1:31 PM