This is an archive of the discontinued LLVM Phabricator instance.

Differential D126755

[mlir][complex] Lower complex.sin/cos to libm
ClosedPublic

Authored by Lewuathe on May 31 2022, 11:11 PM.

Details

Reviewers
ftynse
pifon2a
Commits
rG9f0869a61dc8: [mlir][complex] Lower complex.sin/cos to libm
Summary

Lower sin/cos operation in complex dialect to libm as a baseline. This follows up to https://reviews.llvm.org/D125550.

Diff Detail

Event Timeline

Lewuathe created this revision.May 31 2022, 11:11 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 31 2022, 11:11 PM
Herald added subscribers: bzcheeseman, sdasgup3, wenzhicui and 20 others. · View Herald Transcript
Lewuathe requested review of this revision.May 31 2022, 11:11 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 31 2022, 11:11 PM
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
Lewuathe added a reviewer: pifon2a.May 31 2022, 11:12 PM
Lewuathe edited the summary of this revision. (Show Details)
Harbormaster completed remote builds in B167195: Diff 433289.May 31 2022, 11:32 PM
pifon2a accepted this revision.Jun 1 2022, 12:23 AM
pifon2a added inline comments.
mlir/test/Conversion/ComplexToLibm/convert-to-libm.mlir
64

nit: you probably do not need -DAG here and below.

66

nit: try to make tests fit 80 chars, for example, by removing obvious things, like : (complex<f64>) -> complex<f64>

This revision is now accepted and ready to land.Jun 1 2022, 12:23 AM
Lewuathe updated this revision to Diff 433669.EditedJun 2 2022, 12:22 AM

Update the patch according to the review.

Harbormaster completed remote builds in B167458: Diff 433669.Jun 2 2022, 12:40 AM
pifon2a accepted this revision.Jun 2 2022, 1:37 AM
Closed by commit rG9f0869a61dc8: [mlir][complex] Lower complex.sin/cos to libm (authored by Lewuathe, committed by pifon2a). · Explain WhyJun 2 2022, 1:48 AM
This revision was automatically updated to reflect the committed changes.
pifon2a added a commit: rG9f0869a61dc8: [mlir][complex] Lower complex.sin/cos to libm.

Revision Contents

PathSize
mlir/
lib/
Conversion/
ComplexToLibm/
4 lines
test/
Conversion/
ComplexToLibm/
26 lines

Diff 433685

mlir/lib/Conversion/ComplexToLibm/ComplexToLibm.cpp

Show First 20 Lines • Show All 67 Lines • ▼ Show 20 Lines
void mlir::populateComplexToLibmConversionPatterns(RewritePatternSet &patterns, void mlir::populateComplexToLibmConversionPatterns(RewritePatternSet &patterns,
PatternBenefit benefit) { PatternBenefit benefit) {
patterns.add<ScalarOpToLibmCall<complex::PowOp>>(patterns.getContext(), patterns.add<ScalarOpToLibmCall<complex::PowOp>>(patterns.getContext(),
"cpowf", "cpow", benefit); "cpowf", "cpow", benefit);
patterns.add<ScalarOpToLibmCall<complex::SqrtOp>>(patterns.getContext(), patterns.add<ScalarOpToLibmCall<complex::SqrtOp>>(patterns.getContext(),
"csqrtf", "csqrt", benefit); "csqrtf", "csqrt", benefit);
patterns.add<ScalarOpToLibmCall<complex::TanhOp>>(patterns.getContext(), patterns.add<ScalarOpToLibmCall<complex::TanhOp>>(patterns.getContext(),
"ctanhf", "ctanh", benefit); "ctanhf", "ctanh", benefit);
patterns.add<ScalarOpToLibmCall<complex::CosOp>>(patterns.getContext(),
"ccosf", "ccos", benefit);
patterns.add<ScalarOpToLibmCall<complex::SinOp>>(patterns.getContext(),
"csinf", "csin", benefit);
} }
namespace { namespace {
struct ConvertComplexToLibmPass struct ConvertComplexToLibmPass
: public ConvertComplexToLibmBase<ConvertComplexToLibmPass> { : public ConvertComplexToLibmBase<ConvertComplexToLibmPass> {
void runOnOperation() override; void runOnOperation() override;
}; };
} // namespace } // namespace
Show All 18 Lines

mlir/test/Conversion/ComplexToLibm/convert-to-libm.mlir

// RUN: mlir-opt %s -convert-complex-to-libm -canonicalize | FileCheck %s // RUN: mlir-opt %s -convert-complex-to-libm -canonicalize | FileCheck %s
// CHECK-DAG: @cpowf(complex<f32>, complex<f32>) -> complex<f32> // CHECK-DAG: @cpowf(complex<f32>, complex<f32>) -> complex<f32>
// CHECK-DAG: @cpow(complex<f64>, complex<f64>) -> complex<f64> // CHECK-DAG: @cpow(complex<f64>, complex<f64>) -> complex<f64>
// CHECK-DAG: @csqrtf(complex<f32>) -> complex<f32> // CHECK-DAG: @csqrtf(complex<f32>) -> complex<f32>
// CHECK-DAG: @csqrt(complex<f64>) -> complex<f64> // CHECK-DAG: @csqrt(complex<f64>) -> complex<f64>
// CHECK-DAG: @ctanhf(complex<f32>) -> complex<f32> // CHECK-DAG: @ctanhf(complex<f32>) -> complex<f32>
// CHECK-DAG: @ctanh(complex<f64>) -> complex<f64> // CHECK-DAG: @ctanh(complex<f64>) -> complex<f64>
// CHECK-DAG: @ccos(complex<f64>) -> complex<f64>
// CHECK-DAG: @csin(complex<f64>) -> complex<f64>
// CHECK-LABEL: func @cpow_caller // CHECK-LABEL: func @cpow_caller
// CHECK-SAME: %[[FLOAT:.*]]: complex<f32> // CHECK-SAME: %[[FLOAT:.*]]: complex<f32>
// CHECK-SAME: %[[DOUBLE:.*]]: complex<f64> // CHECK-SAME: %[[DOUBLE:.*]]: complex<f64>
func.func @cpow_caller(%float: complex<f32>, %double: complex<f64>) -> (complex<f32>, complex<f64>) { func.func @cpow_caller(%float: complex<f32>, %double: complex<f64>) -> (complex<f32>, complex<f64>) {
// CHECK-DAG: %[[FLOAT_RESULT:.*]] = call @cpowf(%[[FLOAT]], %[[FLOAT]]) : (complex<f32>, complex<f32>) -> complex<f32> // CHECK-DAG: %[[FLOAT_RESULT:.*]] = call @cpowf(%[[FLOAT]], %[[FLOAT]]) : (complex<f32>, complex<f32>) -> complex<f32>
%float_result = complex.pow %float, %float : complex<f32> %float_result = complex.pow %float, %float : complex<f32>
// CHECK-DAG: %[[DOUBLE_RESULT:.*]] = call @cpow(%[[DOUBLE]], %[[DOUBLE]]) : (complex<f64>, complex<f64>) -> complex<f64> // CHECK-DAG: %[[DOUBLE_RESULT:.*]] = call @cpow(%[[DOUBLE]], %[[DOUBLE]]) : (complex<f64>, complex<f64>) -> complex<f64>
Show All 20 Lines
func.func @ctanh_caller(%float: complex<f32>, %double: complex<f64>) -> (complex<f32>, complex<f64>) { func.func @ctanh_caller(%float: complex<f32>, %double: complex<f64>) -> (complex<f32>, complex<f64>) {
// CHECK-DAG: %[[FLOAT_RESULT:.*]] = call @ctanhf(%[[FLOAT]]) : (complex<f32>) -> complex<f32> // CHECK-DAG: %[[FLOAT_RESULT:.*]] = call @ctanhf(%[[FLOAT]]) : (complex<f32>) -> complex<f32>
%float_result = complex.tanh %float : complex<f32> %float_result = complex.tanh %float : complex<f32>
// CHECK-DAG: %[[DOUBLE_RESULT:.*]] = call @ctanh(%[[DOUBLE]]) : (complex<f64>) -> complex<f64> // CHECK-DAG: %[[DOUBLE_RESULT:.*]] = call @ctanh(%[[DOUBLE]]) : (complex<f64>) -> complex<f64>
%double_result = complex.tanh %double : complex<f64> %double_result = complex.tanh %double : complex<f64>
// CHECK: return %[[FLOAT_RESULT]], %[[DOUBLE_RESULT]] // CHECK: return %[[FLOAT_RESULT]], %[[DOUBLE_RESULT]]
return %float_result, %double_result : complex<f32>, complex<f64> return %float_result, %double_result : complex<f32>, complex<f64>
} }
// CHECK-LABEL: func @ccos_caller
// CHECK-SAME: %[[FLOAT:.*]]: complex<f32>
// CHECK-SAME: %[[DOUBLE:.*]]: complex<f64>
func.func @ccos_caller(%float: complex<f32>, %double: complex<f64>) -> (complex<f32>, complex<f64>) {
// CHECK: %[[FLOAT_RESULT:.*]] = call @ccosf(%[[FLOAT]])
%float_result = complex.cos %float : complex<f32>
// CHECK: %[[DOUBLE_RESULT:.*]] = call @ccos(%[[DOUBLE]])
%double_result = complex.cos %double : complex<f64>
// CHECK: return %[[FLOAT_RESULT]], %[[DOUBLE_RESULT]]
return %float_result, %double_result : complex<f32>, complex<f64>
}
// CHECK-LABEL: func @csin_caller
// CHECK-SAME: %[[FLOAT:.*]]: complex<f32>
// CHECK-SAME: %[[DOUBLE:.*]]: complex<f64>
func.func @csin_caller(%float: complex<f32>, %double: complex<f64>) -> (complex<f32>, complex<f64>) {
// CHECK: %[[FLOAT_RESULT:.*]] = call @csinf(%[[FLOAT]])
pifon2aUnsubmitted
Not Done
ReplyInline Actions

nit: you probably do not need -DAG here and below.

pifon2a: nit: you probably do not need `-DAG` here and below.
%float_result = complex.sin %float : complex<f32>
// CHECK: %[[DOUBLE_RESULT:.*]] = call @csin(%[[DOUBLE]])
pifon2aUnsubmitted
Not Done
ReplyInline Actions

nit: try to make tests fit 80 chars, for example, by removing obvious things, like : (complex<f64>) -> complex<f64>

pifon2a: nit: try to make tests fit 80 chars, for example, by removing obvious things, like `…
%double_result = complex.sin %double : complex<f64>
// CHECK: return %[[FLOAT_RESULT]], %[[DOUBLE_RESULT]]
return %float_result, %double_result : complex<f32>, complex<f64>
}
No newline at end of file