Page MenuHomePhabricator

[analyzer] Remove whitespace in source code
ClosedPublic

Authored by honggyu.kim on Sep 7 2015, 5:47 AM.

Details

Summary

This patch just removes whitespace at the end of each line.
It only modifies source files related to static analyzer.

Diff Detail

Event Timeline

honggyu.kim updated this revision to Diff 34150.Sep 7 2015, 5:47 AM
honggyu.kim retitled this revision from to [analyzer] Remove whitespace in source code.
honggyu.kim updated this object.
honggyu.kim added a subscriber: cfe-commits.

If anyone thinks this patch is too big, I can submit smaller separated patches.

Note: I am not the owner of this code but to me, this should be committed without a review.

honggyu.kim edited edge metadata.Sep 7 2015, 6:21 AM
honggyu.kim added a subscriber: ayartsev.

Note: I am not the owner of this code but to me, this should be committed without a review.

I don't have commit permission, so please anyone commit it instead of me.

We generally don't do large whitespace changes like this because of issue
with version control (not all told are whitespace ignorant which makes
history work difficult).

I don't mind these changes personally, but it should get sign of from Ted
or similar first.

We generally don't do large whitespace changes like this because of issue
with version control (not all told are whitespace ignorant which makes
history work difficult).

I agree that it would be difficult to trace the history of svn or git.
But I wrote this patch because it would be better to have cleaner source code.
If we don't make whitespace in the future changes, it would be okay to trace the history in the long term.

I don't mind these changes personally, but it should get sign of from Ted
or similar first.

I know it can be just a matter of preference, so someone who is in charge of this code can make decision.
I'm also okay if they don't accept this patch.
Thanks for the comment.

krememek edited edge metadata.Sep 7 2015, 8:49 PM

I am OK with taking these changes. For those using git, git blame -w should suffice to show the real blame history.

krememek accepted this revision.Sep 7 2015, 8:52 PM
krememek edited edge metadata.

Committed in r246978.

This revision is now accepted and ready to land.Sep 7 2015, 8:52 PM
krememek closed this revision.Sep 7 2015, 8:53 PM