This is an archive of the discontinued LLVM Phabricator instance.

[JITLink][ELF/AARCH64][NFC] Add a testcase for R_AARCH64_ABS64
AbandonedPublic

Authored by sunho on May 30 2022, 8:30 AM.

Details

Reviewers
lhames
sgraenitz
Summary

Add jitlink-check test cases for R_AARCH64_ABS64 relocation type.

Diff Detail

Event Timeline

sunho created this revision.May 30 2022, 8:30 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 30 2022, 8:30 AM
sunho requested review of this revision.May 30 2022, 8:30 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 30 2022, 8:30 AM
sunho updated this revision to Diff 432950.May 30 2022, 9:23 AM

If it's not too much effort, can we abandon review and add it to the one with the implementation in D126658? You tracked the dependencies here in Phabricator nicely, but it's usually easier for people to see their relation in the git history if it's one commit. All functional changes need testing and so checking them in together is good practice. Thanks!