This is an archive of the discontinued LLVM Phabricator instance.

[libc++][test] Remove Clang <= 3.7 workaround in is_default_constructible test
ClosedPublic

Authored by jloser on May 28 2022, 4:10 PM.

Details

Summary

Clang 3.7 and below is not actively used or supported in the test suite now, so
remove the workaround in the test.

Diff Detail

Event Timeline

jloser created this revision.May 28 2022, 4:10 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 28 2022, 4:10 PM
jloser requested review of this revision.May 28 2022, 4:10 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 28 2022, 4:10 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Mordante accepted this revision.May 29 2022, 6:08 AM

LGTM, thanks! The Apple failures are the one I fixed earlier today.

This revision is now accepted and ready to land.May 29 2022, 6:08 AM
jloser updated this revision to Diff 432790.May 29 2022, 8:17 AM

Rebase to fix CI error with modules build being broken. If this passes CI, I'll land it.