This is an archive of the discontinued LLVM Phabricator instance.

Differential D126548

[InstrProf] Stop exporting lprofDirMode
ClosedPublic

Authored by abrachet on May 27 2022, 8:05 AM.

Details

Reviewers
probinson
vsk
paquette
Commits
rG35a032eaf429: [InstrProf] Stop exporting lprofDirMode
Summary

This symbol should not be exposed and doesn't need to be.

Diff Detail

Event Timeline

abrachet created this revision.May 27 2022, 8:05 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 27 2022, 8:05 AM
Herald added a subscriber: ellis. · View Herald Transcript
abrachet requested review of this revision.May 27 2022, 8:05 AM
Herald added a subscriber: MaskRay. · View Herald TranscriptMay 27 2022, 8:05 AM
Harbormaster completed remote builds in B166656: Diff 432566.May 27 2022, 8:38 AM
vsk accepted this revision.May 27 2022, 10:05 AM
vsk added a reviewer: paquette.
This revision is now accepted and ready to land.May 27 2022, 10:05 AM
Closed by commit rG35a032eaf429: [InstrProf] Stop exporting lprofDirMode (authored by abrachet). · Explain WhyMay 31 2022, 10:13 AM
This revision was automatically updated to reflect the committed changes.
abrachet added a commit: rG35a032eaf429: [InstrProf] Stop exporting lprofDirMode.
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptMay 31 2022, 10:13 AM
Herald added subscribers: Restricted Project, cfe-commits, Enna1. · View Herald Transcript

Revision Contents

PathSize
clang/
lib/
Driver/
ToolChains/
1 line
compiler-rt/
lib/
profile/
2 lines

Diff 433125

clang/lib/Driver/ToolChains/Darwin.cpp

Show First 20 Lines • Show All 1,343 Lines • ▼ Show 20 Lines if (ForGCOV) {
addExportedSymbol(CmdArgs, "___gcov_dump"); addExportedSymbol(CmdArgs, "___gcov_dump");
addExportedSymbol(CmdArgs, "___gcov_reset"); addExportedSymbol(CmdArgs, "___gcov_reset");
addExportedSymbol(CmdArgs, "_writeout_fn_list"); addExportedSymbol(CmdArgs, "_writeout_fn_list");
addExportedSymbol(CmdArgs, "_reset_fn_list"); addExportedSymbol(CmdArgs, "_reset_fn_list");
} else { } else {
addExportedSymbol(CmdArgs, "___llvm_profile_filename"); addExportedSymbol(CmdArgs, "___llvm_profile_filename");
addExportedSymbol(CmdArgs, "___llvm_profile_raw_version"); addExportedSymbol(CmdArgs, "___llvm_profile_raw_version");
} }
addExportedSymbol(CmdArgs, "_lprofDirMode");
} }
// Align __llvm_prf_{cnts,data} sections to the maximum expected page // Align __llvm_prf_{cnts,data} sections to the maximum expected page
// alignment. This allows profile counters to be mmap()'d to disk. Note that // alignment. This allows profile counters to be mmap()'d to disk. Note that
// it's not enough to just page-align __llvm_prf_cnts: the following section // it's not enough to just page-align __llvm_prf_cnts: the following section
// must also be page-aligned so that its data is not clobbered by mmap(). // must also be page-aligned so that its data is not clobbered by mmap().
// //
// The section alignment is only needed when continuous profile sync is // The section alignment is only needed when continuous profile sync is
▲ Show 20 Lines • Show All 1,874 Lines • Show Last 20 Lines

compiler-rt/lib/profile/InstrProfilingUtil.c

Show All 40 Lines
#if defined(__FreeBSD__) #if defined(__FreeBSD__)
#include <signal.h> #include <signal.h>
#include <sys/procctl.h> #include <sys/procctl.h>
#endif #endif
#include "InstrProfiling.h" #include "InstrProfiling.h"
#include "InstrProfilingUtil.h" #include "InstrProfilingUtil.h"
COMPILER_RT_WEAK unsigned lprofDirMode = 0755; COMPILER_RT_VISIBILITY unsigned lprofDirMode = 0755;
COMPILER_RT_VISIBILITY COMPILER_RT_VISIBILITY
void __llvm_profile_recursive_mkdir(char *path) { void __llvm_profile_recursive_mkdir(char *path) {
int i; int i;
int start = 1; int start = 1;
#if defined(__ANDROID__) && defined(__ANDROID_API__) && \ #if defined(__ANDROID__) && defined(__ANDROID_API__) && \
defined(__ANDROID_API_FUTURE__) && \ defined(__ANDROID_API_FUTURE__) && \
▲ Show 20 Lines • Show All 318 Lines • Show Last 20 Lines