Page MenuHomePhabricator

[libunwind][CMake] Fix name of LIBUNWIND_SUPPORTS_NODEFAULTLIBS_FLAG
ClosedPublic

Authored by psamolysov on May 26 2022, 7:16 AM.

Details

Summary

The CMake variable LIBUNWIND_SUPPORTS_NODEFAULTLIBS_FLAG has been renamed
into C_SUPPORTS_NODEFAULTLIBS_FLAG because the last one is used in the
confix-ix.cmake file while the variable with the original name is not used
at al.

Diff Detail

Event Timeline

psamolysov created this revision.May 26 2022, 7:16 AM
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 26 2022, 7:16 AM
Herald added a project: Restricted Project. · View Herald Transcript
psamolysov requested review of this revision.May 26 2022, 7:16 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 26 2022, 7:16 AM
Ericson2314 accepted this revision.May 26 2022, 7:21 AM

Thanks for catching! I suspect this might explain why some of the refactors @phosek and I were doing before did not work.

@Ericson2314 Thank you for the comment. I'm going to land this small patch in a day if there will be no objections.

mstorsjo accepted this revision.May 26 2022, 8:11 AM

LGTM. It looks like this is my mistake from D110005.

This revision is now accepted and ready to land.May 26 2022, 8:11 AM