Page MenuHomePhabricator
Differential D126298

[SLP]Fix PR55653: emit undefs where required, not poison.
ClosedPublic
Actions

Authored by ABataev on May 24 2022, 6:58 AM.

Details

Reviewers
RKSimon
fhahn
nlopes
Commits
rG120d52b0ef8b: [SLP]Fix PR55653: emit undefs where required, not poison.
Summary

Need to handle a corner case correctly, if all elements are Undefs/Poisons,
need to emit actual values, not just poisons.

Diff Detail

Event Timeline

ABataev created this revision.May 24 2022, 6:58 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 24 2022, 6:58 AM
Herald added subscribers: vporpo, hiraditya. · View Herald Transcript
ABataev requested review of this revision.May 24 2022, 6:58 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 24 2022, 6:58 AM
Harbormaster completed remote builds in B166046: Diff 431663.May 24 2022, 7:32 AM
RKSimon accepted this revision.May 26 2022, 7:07 AM

LGTM

This revision is now accepted and ready to land.May 26 2022, 7:07 AM
This revision was landed with ongoing or failed builds.May 26 2022, 8:39 AM
Closed by commit rG120d52b0ef8b: [SLP]Fix PR55653: emit undefs where required, not poison. (authored by ABataev). · Explain Why
This revision was automatically updated to reflect the committed changes.
ABataev added a commit: rG120d52b0ef8b: [SLP]Fix PR55653: emit undefs where required, not poison..

Revision Contents
Changeset List

PathSize
llvm/
lib/
Transforms/
Vectorize/
4 lines
test/
Transforms/
SLPVectorizer/
AArch64/
4 lines
SystemZ/
2 lines
X86/
12 lines
6 lines
2 lines
4 lines
6 lines
2 lines
4 lines
4 lines

Diff 432297

View Options

llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp

Loading...
View Options

llvm/test/Transforms/SLPVectorizer/AArch64/reorder-fmuladd-crash.ll

Loading...
View Options

llvm/test/Transforms/SLPVectorizer/SystemZ/pr34619.ll

Loading...
View Options

llvm/test/Transforms/SLPVectorizer/X86/horizontal-minmax.ll

Loading...
View Options

llvm/test/Transforms/SLPVectorizer/X86/insert-shuffle.ll

Loading...
View Options

llvm/test/Transforms/SLPVectorizer/X86/jumbled-load-used-in-phi.ll

Loading...
View Options

llvm/test/Transforms/SLPVectorizer/X86/partail.ll

Loading...
View Options

llvm/test/Transforms/SLPVectorizer/X86/shrink_after_reorder.ll

Loading...
View Options

llvm/test/Transforms/SLPVectorizer/X86/shrink_after_reorder2.ll

Loading...
View Options

llvm/test/Transforms/SLPVectorizer/X86/vectorize-reorder-alt-shuffle.ll

Loading...
View Options

llvm/test/Transforms/SLPVectorizer/slp-umax-rdx-matcher-crash.ll

Loading...