This is an archive of the discontinued LLVM Phabricator instance.

Differential D126265

[Hexagon] Fix test on OpenBSD
ClosedPublic

Authored by brad on May 23 2022, 7:31 PM.

Details

Reviewers
kparzysz
MaskRay
Commits
rG244494a201f8: [Hexagon] Fix test on OpenBSD
Summary

The test specifies a CPU arch but not a particular OS. So if run on OpenBSD it acts as if it's an OpenBSD/hexagon system. OpenBSD uses guard_local instead of stack_chk_guard so the test will fail. So specify an OS other than OpenBSD fixes the tet.

Diff Detail

Unit TestsFailed

TimeTest
60,110 msx64 debian > AddressSanitizer-x86_64-linux-dynamic.TestCases::scariness_score_test.cpp
60,050 msx64 debian > MLIR.Examples/standalone::test.toy
60,030 msx64 debian > libFuzzer.libFuzzer::fuzzer-leak.test

Event Timeline

brad created this revision.May 23 2022, 7:31 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 23 2022, 7:31 PM
Herald added a subscriber: krytarowski. · View Herald Transcript
brad requested review of this revision.May 23 2022, 7:31 PM
brad added a reviewer: MaskRay.
Herald added a subscriber: StephenFan. · View Herald TranscriptMay 23 2022, 7:31 PM
MaskRay accepted this revision.May 23 2022, 8:05 PM

LGTM.

This revision is now accepted and ready to land.May 23 2022, 8:05 PM
Harbormaster completed remote builds in B165979: Diff 431557.May 23 2022, 8:16 PM
This revision was landed with ongoing or failed builds.May 23 2022, 8:30 PM
Closed by commit rG244494a201f8: [Hexagon] Fix test on OpenBSD (authored by brad). · Explain Why
This revision was automatically updated to reflect the committed changes.
brad added a commit: rG244494a201f8: [Hexagon] Fix test on OpenBSD.
awilfox mentioned this in D126637: [Hexagon][test] Fix tests on Linux/musl.May 31 2022, 9:07 PM

Revision Contents

PathSize
llvm/
test/
CodeGen/
Hexagon/
4 lines

Diff 431557

llvm/test/CodeGen/Hexagon/sdata-stack-guard.ll

; Check that the __stack_chk_guard was placed in small data. ; Check that the __stack_chk_guard was placed in small data.
; RUN: llc -march=hexagon -O2 -hexagon-small-data-threshold=4 < %s | FileCheck -check-prefix=GPREL %s ; RUN: llc -march=hexagon -mtriple=hexagon-unknown-linux-gnu -O2 -hexagon-small-data-threshold=4 < %s | FileCheck -check-prefix=GPREL %s
; GPREL: memw(gp+#__stack_chk_guard) ; GPREL: memw(gp+#__stack_chk_guard)
; For threshold less than 4 (size of address), the variable is not placed in small-data ; For threshold less than 4 (size of address), the variable is not placed in small-data
; RUN: llc -march=hexagon -O2 -hexagon-small-data-threshold=0 < %s | FileCheck -check-prefix=ABS %s ; RUN: llc -march=hexagon -mtriple=hexagon-unknown-linux-gnu -O2 -hexagon-small-data-threshold=0 < %s | FileCheck -check-prefix=ABS %s
; ABS: memw(##__stack_chk_guard) ; ABS: memw(##__stack_chk_guard)
@g0 = private unnamed_addr constant [37 x i8] c"This string is longer than 16 bytes\0A\00", align 1 @g0 = private unnamed_addr constant [37 x i8] c"This string is longer than 16 bytes\0A\00", align 1