This is an archive of the discontinued LLVM Phabricator instance.

Test stackmap support for i128
ClosedPublic

Authored by vext01 on May 20 2022, 7:42 AM.

Details

Summary

This diff adds tests that check the currently-working stackmap cases for i128. This will help ensure no regressions are later introduced by D125680 (when ready).

Note that i128 stackmap support is currently incomplete, so we cant test all i128 functionality:

So this change tests only constant i128 operands of value < 2^{63}.

A couple of incorrect comments are also fixed.

Diff Detail

Event Timeline

vext01 created this revision.May 20 2022, 7:42 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 20 2022, 7:42 AM
vext01 requested review of this revision.May 20 2022, 7:42 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 20 2022, 7:42 AM

By the way, am I right in thinking that there are no tests that actually check that the reported stackmap locations are correct at runtime?

t.p.northover accepted this revision.May 23 2022, 3:02 AM
t.p.northover added a subscriber: t.p.northover.

Seems reasonable to test what we can now, so I reckon this is fine.

This revision is now accepted and ready to land.May 23 2022, 3:02 AM
vext01 closed this revision.Jun 8 2022, 5:35 AM

This was merged by Tim in c5e5cf12583.

Thanks