This is an archive of the discontinued LLVM Phabricator instance.

[InstCombine] Precommit test for D125750.
ClosedPublic

Authored by jacquesguan on May 20 2022, 2:34 AM.

Diff Detail

Event Timeline

jacquesguan created this revision.May 20 2022, 2:34 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 20 2022, 2:34 AM
jacquesguan requested review of this revision.May 20 2022, 2:34 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 20 2022, 2:34 AM
spatel added inline comments.May 24 2022, 5:41 AM
llvm/test/Transforms/InstCombine/extractelement.ll
4–5

In most of these tests, LE64 will be the same as LE128, and BE64 will be the same as BE128. Can we make common prefixes for those 2 pairs of runs?

Add test to show improve of D125750.

jacquesguan added inline comments.Aug 26 2022, 12:22 AM
llvm/test/Transforms/InstCombine/extractelement.ll
4–5

Done, thanks.

spatel added inline comments.Aug 26 2022, 5:53 AM
llvm/test/Transforms/InstCombine/extractelement.ll
4–5

This is not what I was thinking. Would it make it the diff smaller like this:

; RUN: opt < %s -passes=instcombine -S -data-layout="e-n64" | FileCheck %s --check-prefixes=ANY,ANYLE,LE64
; RUN: opt < %s -passes=instcombine -S -data-layout="e-n128" | FileCheck %s --check-prefixes=ANY,ANYLE,LE128
; RUN: opt < %s -passes=instcombine -S -data-layout="E-n64" | FileCheck %s --check-prefixes=ANY,ANYBE,BE64
; RUN: opt < %s -passes=instcombine -S -data-layout="E-n128" | FileCheck %s --check-prefixes=ANY,ANYBE,BE128

Address comment.

jacquesguan added inline comments.Aug 28 2022, 11:51 PM
llvm/test/Transforms/InstCombine/extractelement.ll
4–5

Done, thanks.

spatel accepted this revision.Aug 29 2022, 7:17 AM

LGTM

This revision is now accepted and ready to land.Aug 29 2022, 7:17 AM
This revision was automatically updated to reflect the committed changes.