This is an archive of the discontinued LLVM Phabricator instance.

[Metadata] Use push_back() to append operands of MDTuples to other MDTuples
ClosedPublic

Authored by wolfgangp on May 19 2022, 11:41 AM.

Diff Detail

Event Timeline

wolfgangp created this revision.May 19 2022, 11:41 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 19 2022, 11:41 AM
Herald added a subscriber: hiraditya. · View Herald Transcript
wolfgangp requested review of this revision.May 19 2022, 11:41 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 19 2022, 11:41 AM

This patch depends on D125998. When appending module flags to the module flags of another module (probably during module linking) we want to append the operands to the destination module's MDTuple instead of creating new ones. This should fix issue 51893.

wolfgangp updated this revision to Diff 431176.May 21 2022, 1:23 PM

Use a better way to create a distinct node from an existing uniqued one and simplify dealing with AppendUnique module flags.

dexonsmith accepted this revision.May 24 2022, 2:06 PM

LGTM once the prep commits land!

This revision is now accepted and ready to land.May 24 2022, 2:06 PM
This revision was landed with ongoing or failed builds.Jul 6 2022, 10:19 AM
This revision was automatically updated to reflect the committed changes.