Differential D125999

[Metadata] Use push_back() to append operands of MDTuples to other MDTuples
ClosedPublic
Actions

Authored by wolfgangp on May 19 2022, 11:41 AM.

Details

Reviewers

dexonsmith

Commits

rGff87ee4dee9c: [Metadata] Utilize the resizing capability of MDNodes in Moduleflag processing.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

wolfgangp created this revision.May 19 2022, 11:41 AM

Herald added a project: Restricted Project. · View Herald TranscriptMay 19 2022, 11:41 AM

Herald added a subscriber: hiraditya. · View Herald Transcript

wolfgangp requested review of this revision.May 19 2022, 11:41 AM

Herald added a project: Restricted Project. · View Herald TranscriptMay 19 2022, 11:41 AM

Herald added a subscriber: llvm-commits. · View Herald Transcript

This patch depends on D125998. When appending module flags to the module flags of another module (probably during module linking) we want to append the operands to the destination module's MDTuple instead of creating new ones. This should fix issue 51893.

wolfgangp added a parent revision: D125998: [Metadata] Add a resize capability to MDNodes and add a push_back interface to MDNodes..May 19 2022, 11:47 AM

Harbormaster completed remote builds in B165377: Diff 430756.May 19 2022, 11:48 AM

Use a better way to create a distinct node from an existing uniqued one and simplify dealing with AppendUnique module flags.

Harbormaster completed remote builds in B165686: Diff 431176.May 21 2022, 2:25 PM

LGTM once the prep commits land!

This revision is now accepted and ready to land.May 24 2022, 2:06 PM

This revision was landed with ongoing or failed builds.Jul 6 2022, 10:19 AM

Closed by commit rGff87ee4dee9c: [Metadata] Utilize the resizing capability of MDNodes in Moduleflag processing. (authored by wolfgangp). · Explain Why

This revision was automatically updated to reflect the committed changes.

wolfgangp added a commit: rGff87ee4dee9c: [Metadata] Utilize the resizing capability of MDNodes in Moduleflag processing..

Herald added a subscriber: Enna1. · View Herald TranscriptJul 6 2022, 10:19 AM