This is an archive of the discontinued LLVM Phabricator instance.

Differential D125921

[SystemZ][z/OS] Add missing include
ClosedPublic

Authored by yusra.syeda on May 18 2022, 12:50 PM.

Details

Reviewers
mib
Kai
uweigand
Commits
rG1e14b1a7977b: [SystemZ][z/OS] Add missing include to llvm/include/llvm/BinaryFormat/GOFF.h
Summary

This patch adds a missing include to llvm/include/llvm/BinaryFormat/GOFF.h

Diff Detail

Unit TestsFailed

TimeTest
60,120 msx64 debian > AddressSanitizer-x86_64-linux.TestCases::scariness_score_test.cpp
60,040 msx64 debian > libFuzzer.libFuzzer::fuzzer-leak.test
60,030 msx64 debian > libFuzzer.libFuzzer::minimize_crash.test
60,040 msx64 debian > libFuzzer.libFuzzer::out-of-process-fuzz.test
60,020 msx64 debian > libFuzzer.libFuzzer::value-profile-load.test

Event Timeline

yusra.syeda created this revision.May 18 2022, 12:50 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 18 2022, 12:50 PM
yusra.syeda requested review of this revision.May 18 2022, 12:50 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 18 2022, 12:50 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
yusra.syeda mentioned this in D125725: [SystemZ][z/OS] Add PPA1 support.May 18 2022, 12:51 PM
mib accepted this revision.May 18 2022, 12:54 PM

LGTM! Thanks!

This revision is now accepted and ready to land.May 18 2022, 12:54 PM
Kai accepted this revision.May 18 2022, 12:54 PM

LGTM.

This revision was landed with ongoing or failed builds.May 18 2022, 12:59 PM
Closed by commit rG1e14b1a7977b: [SystemZ][z/OS] Add missing include to llvm/include/llvm/BinaryFormat/GOFF.h (authored by yusra.syeda). · Explain Why
This revision was automatically updated to reflect the committed changes.
yusra.syeda added a commit: rG1e14b1a7977b: [SystemZ][z/OS] Add missing include to llvm/include/llvm/BinaryFormat/GOFF.h.
Harbormaster completed remote builds in B165193: Diff 430479.May 18 2022, 1:25 PM

Revision Contents

PathSize
llvm/
include/
llvm/
BinaryFormat/
2 lines

Diff 430479

llvm/include/llvm/BinaryFormat/GOFF.h

Show All 9 Lines
// constants for the GOFF file format. // constants for the GOFF file format.
// //
// GOFF specifics can be found in MVS Program Management: Advanced Facilities // GOFF specifics can be found in MVS Program Management: Advanced Facilities
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
#ifndef LLVM_BINARYFORMAT_GOFF_H #ifndef LLVM_BINARYFORMAT_GOFF_H
#define LLVM_BINARYFORMAT_GOFF_H #define LLVM_BINARYFORMAT_GOFF_H
#include "llvm/Support/DataTypes.h"
namespace llvm { namespace llvm {
namespace GOFF { namespace GOFF {
// \brief Subsections of the primary C_CODE section in the object file. // \brief Subsections of the primary C_CODE section in the object file.
enum SubsectionKind : uint8_t { enum SubsectionKind : uint8_t {
SK_PPA1 = 2, SK_PPA1 = 2,
}; };
} // end namespace GOFF } // end namespace GOFF
} // end namespace llvm } // end namespace llvm
#endif // LLVM_BINARYFORMAT_GOFF_H #endif // LLVM_BINARYFORMAT_GOFF_H