Page MenuHomePhabricator

[Sanitizers][Darwin] Rename Apple macro SANITIZER_MAC -> SANITIZER_APPLE
ClosedPublic

Authored by wrotki on May 17 2022, 10:40 AM.

Details

Summary

Initial introduction of the new macro before obsoleting the old one - the old name was really confusing.
Also moved SANITIZER_WATCHOS and SANITIZER_TVOS definitions under common #if defined(APPLE) block

Diff Detail

Event Timeline

wrotki created this revision.May 17 2022, 10:40 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 17 2022, 10:40 AM
wrotki requested review of this revision.May 17 2022, 10:40 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 17 2022, 10:40 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript
yln added inline comments.May 17 2022, 10:43 AM
compiler-rt/lib/sanitizer_common/sanitizer_platform.h
78

Is TARGET_OS_IPHONE needed here?

wrotki updated this revision to Diff 430128.May 17 2022, 10:57 AM

Removed unneccessary conditional

yln accepted this revision.May 17 2022, 10:57 AM
This revision is now accepted and ready to land.May 17 2022, 10:57 AM
wrotki updated this revision to Diff 430423.May 18 2022, 9:51 AM

Re-adding missing #else line

yln added inline comments.May 18 2022, 10:02 AM
compiler-rt/lib/sanitizer_common/sanitizer_platform.h
94

We are missing SANITIZER_WATCHOS and SANITIZER_TVOS here in the non-Apple case.

wrotki updated this revision to Diff 430442.May 18 2022, 10:31 AM

Added SANITIZER_WATCHOS and SANITIZER_TVOS for the non-Apple case

wrotki marked an inline comment as done.May 18 2022, 10:39 AM
wrotki added inline comments.
compiler-rt/lib/sanitizer_common/sanitizer_platform.h
94

The diff looks a bit weird here (reviews.llvm,.org) , but I think it's still correct. I'll retest just in case.

This revision was landed with ongoing or failed builds.May 18 2022, 2:46 PM
This revision was automatically updated to reflect the committed changes.
wrotki marked an inline comment as done.