This is an archive of the discontinued LLVM Phabricator instance.

Differential D129502

[Sanitizers][Darwin] Remove SANITIZER_MAC
ClosedPublic

Authored by wrotki on Jul 11 2022, 10:26 AM.

Details

Reviewers
rsundahl
thetruestblue
yln
Commits
rGaf0a26b47661: [Sanitizers][Darwin] Remove SANITIZER_MAC
Summary

This is to finish the change started by D125816 , D126263 and D126577 (replace SANITIZER_MAC by SANITIZER_APPLE).
Dropping definition of SANITIZER_MAC completely, to remove any possible confusion.

Diff Detail

Event Timeline

wrotki created this revision.Jul 11 2022, 10:26 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 11 2022, 10:26 AM
Herald added a subscriber: Enna1. · View Herald Transcript
wrotki requested review of this revision.Jul 11 2022, 10:26 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 11 2022, 10:26 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript
thetruestblue added a comment.Jul 11 2022, 10:35 AM
This comment was removed by thetruestblue.
thetruestblue accepted this revision.Jul 11 2022, 10:36 AM

LGTM

This revision is now accepted and ready to land.Jul 11 2022, 10:36 AM
Harbormaster completed remote builds in B174699: Diff 443682.Jul 11 2022, 10:44 AM
yln accepted this revision.Jul 11 2022, 11:00 AM
Closed by commit rGaf0a26b47661: [Sanitizers][Darwin] Remove SANITIZER_MAC (authored by wrotki). · Explain WhyJul 12 2022, 9:11 AM
This revision was automatically updated to reflect the committed changes.
wrotki added a commit: rGaf0a26b47661: [Sanitizers][Darwin] Remove SANITIZER_MAC.

Revision Contents

PathSize
compiler-rt/
lib/
sanitizer_common/
5 lines

Diff 443981

compiler-rt/lib/sanitizer_common/sanitizer_platform.h

Show First 20 Lines • Show All 58 Lines • ▼ Show 20 Lines
// - TARGET_OS_OSX: macOS // - TARGET_OS_OSX: macOS
// - SANITIZER_IOS: devices (iOS and iOS-like) // - SANITIZER_IOS: devices (iOS and iOS-like)
// - SANITIZER_WATCHOS // - SANITIZER_WATCHOS
// - SANITIZER_TVOS // - SANITIZER_TVOS
// - SANITIZER_IOSSIM: simulators (iOS and iOS-like) // - SANITIZER_IOSSIM: simulators (iOS and iOS-like)
// - SANITIZER_DRIVERKIT // - SANITIZER_DRIVERKIT
#if defined(__APPLE__) #if defined(__APPLE__)
# define SANITIZER_APPLE 1 # define SANITIZER_APPLE 1
// SANITIZER_MAC will be deprecated/removed in the future
# define SANITIZER_MAC \
error "SANITIZER_MAC will be removed, please use SANITIZER_APPLE"
# include <TargetConditionals.h> # include <TargetConditionals.h>
# if TARGET_OS_OSX # if TARGET_OS_OSX
# define SANITIZER_OSX 1 # define SANITIZER_OSX 1
# else # else
# define SANITIZER_OSX 0 # define SANITIZER_OSX 0
# endif # endif
# if TARGET_OS_IPHONE # if TARGET_OS_IPHONE
# define SANITIZER_IOS 1 # define SANITIZER_IOS 1
Show All 17 Lines
# endif # endif
# if TARGET_OS_DRIVERKIT # if TARGET_OS_DRIVERKIT
# define SANITIZER_DRIVERKIT 1 # define SANITIZER_DRIVERKIT 1
# else # else
# define SANITIZER_DRIVERKIT 0 # define SANITIZER_DRIVERKIT 0
# endif # endif
#else #else
# define SANITIZER_APPLE 0 # define SANITIZER_APPLE 0
# define SANITIZER_MAC \
error "SANITIZER_MAC will be removed, please use SANITIZER_APPLE"
# define SANITIZER_OSX 0 # define SANITIZER_OSX 0
# define SANITIZER_IOS 0 # define SANITIZER_IOS 0
# define SANITIZER_WATCHOS 0 # define SANITIZER_WATCHOS 0
# define SANITIZER_TVOS 0 # define SANITIZER_TVOS 0
# define SANITIZER_IOSSIM 0 # define SANITIZER_IOSSIM 0
# define SANITIZER_DRIVERKIT 0 # define SANITIZER_DRIVERKIT 0
#endif #endif
▲ Show 20 Lines • Show All 336 Lines • Show Last 20 Lines