This is an archive of the discontinued LLVM Phabricator instance.

Differential D125763

[pgo] Fix doc typo: thingswith -> things with
ClosedPublic

Authored by kwk on May 17 2022, 3:50 AM.

Details

Reviewers
george.burgess.iv
thakis
Commits
rG329dc5587cea: [pgo] Fix doc typo: thingswith -> things with
Summary

The title says it all.

Diff Detail

Unit TestsFailed

TimeTest
60,130 msx64 debian > LLVM.CodeGen/NVPTX::wmma.py
60,170 msx64 debian > LLVM.MC/Mips::mips-jump-pc-region.s

Event Timeline

kwk created this revision.May 17 2022, 3:50 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 17 2022, 3:50 AM
Herald added a subscriber: wenlei. · View Herald Transcript
kwk requested review of this revision.May 17 2022, 3:50 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 17 2022, 3:50 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
kwk added reviewers: george.burgess.iv, thakis.May 17 2022, 3:52 AM
Harbormaster completed remote builds in B164841: Diff 429994.May 17 2022, 4:41 AM
thakis accepted this revision.May 17 2022, 5:09 AM

Thanks!

Do you have commit access?

This revision is now accepted and ready to land.May 17 2022, 5:09 AM
This revision was landed with ongoing or failed builds.May 17 2022, 6:01 AM
Closed by commit rG329dc5587cea: [pgo] Fix doc typo: thingswith -> things with (authored by kwk). · Explain Why
This revision was automatically updated to reflect the committed changes.
kwk added a commit: rG329dc5587cea: [pgo] Fix doc typo: thingswith -> things with.
kwk added a comment.May 17 2022, 6:01 AM
In D125763#3518621, @thakis wrote:

Thanks!

Do you have commit access?

Yes I have. Thank you for accepting this patch-

Revision Contents

PathSize
llvm/
utils/
2 lines

Diff 429994

llvm/utils/collect_and_build_with_pgo.py

Show First 20 Lines • Show All 314 Lines • ▼ Show 20 LinesArgs = collections.namedtuple('Args', [
'profile_location', 'profile_location',
'stage1_dir', 'stage1_dir',
]) ])
def _parse_args(): def _parse_args():
parser = argparse.ArgumentParser( parser = argparse.ArgumentParser(
description='Builds LLVM and Clang with instrumentation, collects ' description='Builds LLVM and Clang with instrumentation, collects '
'instrumentation profiles for them, and (optionally) builds things' 'instrumentation profiles for them, and (optionally) builds things '
'with these PGO profiles. By default, it\'s assumed that you\'re ' 'with these PGO profiles. By default, it\'s assumed that you\'re '
'running this from your LLVM root, and all build artifacts will be ' 'running this from your LLVM root, and all build artifacts will be '
'saved to $PWD/out.') 'saved to $PWD/out.')
parser.add_argument( parser.add_argument(
'--cmake-extra-arg', '--cmake-extra-arg',
action='append', action='append',
default=[], default=[],
help='an extra arg to pass to all cmake invocations. Note that this ' help='an extra arg to pass to all cmake invocations. Note that this '
▲ Show 20 Lines • Show All 152 Lines • Show Last 20 Lines