This is an archive of the discontinued LLVM Phabricator instance.

Differential D125696

[BasicBlockUtils] Add corner case test for loop metadata.
ClosedPublic

Authored by hgreving on May 16 2022, 8:48 AM.

Details

Reviewers
fhahn
Meinersbur
reames
aeubanks
Commits
rGe5d8fb690e35: [BasicBlockUtils] Add corner case test for loop metadata.
Summary

Adds a test to expose #55416.

Diff Detail

Unit TestsFailed

TimeTest
60,110 msx64 debian > LLVM.CodeGen/NVPTX::wmma.py
60,050 msx64 debian > ThreadSanitizer-x86_64.ThreadSanitizer-x86_64::restore_stack.cpp

Event Timeline

hgreving created this revision.May 16 2022, 8:48 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 16 2022, 8:48 AM
hgreving requested review of this revision.May 16 2022, 8:48 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 16 2022, 8:48 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
hgreving mentioned this in D125574: [BasicBlockUtils] Do not move loop metadata if outer loop header..May 16 2022, 8:49 AM
hgreving updated this revision to Diff 429735.May 16 2022, 8:55 AM
Harbormaster completed remote builds in B164660: Diff 429735.May 16 2022, 9:47 AM
hgreving added a reviewer: Meinersbur.May 23 2022, 2:08 PM
hgreving added a reviewer: reames.
aeubanks accepted this revision.May 23 2022, 4:16 PM
aeubanks added a subscriber: aeubanks.

precommitting a test for an approved patch generally shouldn't require review

This revision is now accepted and ready to land.May 23 2022, 4:16 PM
hgreving added a comment.May 23 2022, 4:19 PM
In D125696#3532788, @aeubanks wrote:

precommitting a test for an approved patch generally shouldn't require review

SG.

This revision was landed with ongoing or failed builds.May 23 2022, 4:41 PM
Closed by commit rGe5d8fb690e35: [BasicBlockUtils] Add corner case test for loop metadata. (authored by hgreving). · Explain Why
This revision was automatically updated to reflect the committed changes.
hgreving added a commit: rGe5d8fb690e35: [BasicBlockUtils] Add corner case test for loop metadata..

Revision Contents

PathSize
llvm/
test/
Transforms/
LoopSimplify/
36 lines

Diff 429735

llvm/test/Transforms/LoopSimplify/update_latch_md2.ll

  • This file was added.
; Tests loop-simplify does not move the loop metadata, because
; the loopexit block is not the latch of the loop _bb6.
; FIXME(#55416): The metadata should not move.
; RUN: opt < %s -passes=loop-simplify -S | FileCheck %s
; CHECK-LABEL: loop.header.loopexit:
; CHECK: br label %loop.header, !llvm.loop !0
; CHECK-LABEL: loop.latch:
; CHECK-NOT: br i1 %p, label %loop.latch, label %loop.header.loopexit, !llvm.loop !0
define void @func(i1 %p) {
entry:
br label %loop.header
loop.header:
br i1 %p, label %bb1, label %exit
bb1:
br i1 %p, label %bb2, label %bb3
bb2:
br label %bb3
bb3:
br label %loop.latch
loop.latch:
br i1 %p, label %loop.latch, label %loop.header, !llvm.loop !0
exit:
ret void
}
!0 = distinct !{!0, !1}
!1 = !{!"llvm.loop.mustprogress"}