User Details
- User Since
- Jan 31 2020, 1:07 PM (126 w, 5 d)
Jun 6 2022
Jun 2 2022
Added more reviewers with history of the modulo expansion code, since I believe there is no feasible test for upstream targets, see commit message.
Jun 1 2022
Reverted the patch in repo and re-pushing again. The only difference of the new push is s/enum_seq_inclusive/enum_seq/ in TargetLoweringBase.cpp.
Rebase only.
May 26 2022
May 25 2022
Updates patch. Let's do it straight forward and support cases where no branch is needed to the fallthrough.
There are a few lit failures, I will look at those first.
May 24 2022
May 23 2022
May 20 2022
Friendly ping on this review.
Friendly ping on this review.
May 16 2022
Rebased to https://reviews.llvm.org/D125696
May 13 2022
Whoa another corner case.
May 10 2022
Added a few clang-format on/off. I suggest to accept some of the enum changes in IntrinsicEmitter.cpp, Function.cpp, it feels unnecessary not to accept clang-format here. I wonder if these deltas are due to different clang-format versions in the past.
Full context update (excl clang-format off notations yet)
clang-format changes. I am aware that some of the changes look like they do not follow existing code. I'm not sure why clang-format does this.
May 9 2022
May 7 2022
Abandoning, may try the integer route or check the sel DAG failures more closely.
May 6 2022
May 5 2022
Apr 21 2022
Apr 20 2022
Mar 22 2022
Mar 21 2022
Sep 21 2021
Seems like that this patch now contradicts the methods MDBuilder.h:createAnonymousAliasScopeDomain and createAnonymousAliasScope. If you actually give it a string, it won't verify. I wonder if you should amend this changing the methods as well?
Jul 20 2021
Jul 19 2021
Besides that this patch created the intrinsics llvm.memset which in our target was unsupported, it also created pointers that may be invalid on the target, e.g. i8 addrspace(X)* where addrspace(X) only supports vector memory. While this is probably all solvable, please consider adding TTI switches for targets to disable this optimization (e.g. for the intrinsics).
Jul 15 2021
Jun 25 2021
Jun 23 2021
Jun 21 2021
Jun 20 2021
Second CHECK line.
clang-format.
Jun 18 2021
Use iterator preincrement instead.
May 26 2021
May 25 2021
For targets not supporting scalar load from vector memory (like ours), this breaks it: