User Details
- User Since
- Jan 31 2020, 1:07 PM (164 w, 2 d)
Wed, Mar 1
Is this compatible with dowstream targets defining their own intrinsics outside of Intrinics.td (in LLVM)?
Feb 13 2023
I wonder if we should add a test for this. Thanks a lot for the fix here.
This change broke our backend. LLVMIRIntrinsicGen.cpp::emitIntrinsic also allows for intrinsics to be included in alias scopes, but it now asserts at ModuleTranslation.cpp:1034 only supporting LoadOp|StoreOp.
Jan 16 2023
Committed at 37c750a5fd13 (forgot to mark in the commit message).
Jan 11 2023
Dec 14 2022
Thanks for review.
Dec 13 2022
Hi I've added reviewers from the git log. I wonder if this change is acceptable which would help us avoiding to downstream the entire pass. Thanks in advance
Oct 19 2022
Sep 14 2022
Sep 13 2022
Ok to me for the convenience method but please get one more opinion
Sep 12 2022
Added missed EVT::getTypeForEVT.
Sep 9 2022
Aug 30 2022
Aug 26 2022
Re-opening
This patch is wrong, abandoning.
Aug 25 2022
Jul 21 2022
Jul 20 2022
LGTM
Jul 19 2022
Jul 18 2022
Are you working on a backend where writing a test for this is feasible, like Hexagon?
1 -> 2, 1 -> 3, 2 -> 3, and 3 -> 1
Assume edges are all weighted 1.
Circuit 1 -> 3 correctly calculated as Latency = 1
Jun 6 2022
Jun 2 2022
Added more reviewers with history of the modulo expansion code, since I believe there is no feasible test for upstream targets, see commit message.
Jun 1 2022
Reverted the patch in repo and re-pushing again. The only difference of the new push is s/enum_seq_inclusive/enum_seq/ in TargetLoweringBase.cpp.
Rebase only.
May 26 2022
May 25 2022
Updates patch. Let's do it straight forward and support cases where no branch is needed to the fallthrough.
There are a few lit failures, I will look at those first.
May 24 2022
May 23 2022
May 20 2022
Friendly ping on this review.
Friendly ping on this review.
May 16 2022
Rebased to https://reviews.llvm.org/D125696
May 13 2022
Whoa another corner case.
May 10 2022
Added a few clang-format on/off. I suggest to accept some of the enum changes in IntrinsicEmitter.cpp, Function.cpp, it feels unnecessary not to accept clang-format here. I wonder if these deltas are due to different clang-format versions in the past.
Full context update (excl clang-format off notations yet)
clang-format changes. I am aware that some of the changes look like they do not follow existing code. I'm not sure why clang-format does this.
May 9 2022
May 7 2022
Abandoning, may try the integer route or check the sel DAG failures more closely.