Page MenuHomePhabricator

[clang][extract-api] Don't emit symbols prefixed with an underscore
ClosedPublic

Authored by dang on May 16 2022, 3:51 AM.

Details

Summary

These symbols are understood to not be used for client API consumption
by convention so they should not appear in the generated symbol graph.

Diff Detail

Event Timeline

dang created this revision.May 16 2022, 3:51 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 16 2022, 3:51 AM
dang requested review of this revision.May 16 2022, 3:51 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 16 2022, 3:51 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
This revision is now accepted and ready to land.May 16 2022, 1:59 PM

clang-format failed:

---  clang-format

changed files:

    clang/test/ExtractAPI/underscored.c
zixuw accepted this revision.May 16 2022, 2:04 PM

clang-format failed:

---  clang-format

changed files:

    clang/test/ExtractAPI/underscored.c

I think it's fine. clang-format always get tripped on split-file tests because of the mixed format and what not.

dang added a comment.May 25 2022, 10:26 AM

clang-format failed:

---  clang-format

changed files:

    clang/test/ExtractAPI/underscored.c

I think it's fine. clang-format always get tripped on split-file tests because of the mixed format and what not.

Yeah this always unfortunately happens can't expect clang format to seamlessly accept to format both C and JSON. Also formatting matters less in tests.

This revision was landed with ongoing or failed builds.May 25 2022, 11:02 AM
This revision was automatically updated to reflect the committed changes.