This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU] Fix typo in cttz_zero_undef(x) -> cttz(x) fold test
ClosedPublic

Authored by RKSimon on May 14 2022, 11:25 AM.

Details

Summary

It looks like v_cttz_zero_undef_i64_with_select should be selecting '64' for the x != 0 case instead of '32' like we just did in the previous 'v_cttz_zero_undef_i32_with_select' test.

I THINK this is a copy+paste typo, but it might have been done on purpose - in which case we probably need a second vesion of the test with the correct value and a better test name.

Noticed by accident because it was causing some weird regressions....

Diff Detail

Event Timeline

RKSimon created this revision.May 14 2022, 11:25 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 14 2022, 11:25 AM
RKSimon requested review of this revision.May 14 2022, 11:25 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 14 2022, 11:25 AM
Herald added a subscriber: wdng. · View Herald Transcript
arsenm accepted this revision.May 14 2022, 12:19 PM
This revision is now accepted and ready to land.May 14 2022, 12:19 PM