Most functions do not need a PatternRewriter or ConversionPatternRewriter.
Depends On D125361
Paths
| Differential D125466
[mlir][sparse][NFC] Use RewriterBase/OpBuilder when possible ClosedPublic Authored by springerm on May 12 2022, 6:11 AM.
Details Summary Most functions do not need a PatternRewriter or ConversionPatternRewriter. Depends On D125361
Diff Detail
Event TimelineComment Actions Changes look good, and it is of course good to require the minimum required type. But is there a major advantage of doing it this way? (follow up or otherwise)? This revision is now accepted and ready to land.May 12 2022, 11:54 AM Comment Actions
The API of One-Shot Bufferize provides a RewriterBase &, so this is needed in a few places to compose with the sparse compiler. Since I was already at it, I went through the entire sparsecompiler codebase and updated all PatternRewriter/ConversionPatternRewriter for consistency. Closed by commit rGe9fa5590971b: [mlir][sparse][NFC] Use RewriterBase/OpBuilder when possible (authored by springerm). · Explain WhyMay 13 2022, 2:37 AM This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 428921 mlir/include/mlir/Dialect/SparseTensor/Utils/Merger.h
mlir/lib/Dialect/SparseTensor/Transforms/SparseTensorConversion.cpp
mlir/lib/Dialect/SparseTensor/Transforms/Sparsification.cpp
mlir/lib/Dialect/SparseTensor/Utils/Merger.cpp
|