This is an archive of the discontinued LLVM Phabricator instance.

[clang] Fix KEYALL
ClosedPublic

Authored by yaxunl on May 11 2022, 8:46 AM.

Details

Summary

Introduce KEYMAX and a generic way to update KEYALL.

Diff Detail

Event Timeline

yaxunl created this revision.May 11 2022, 8:46 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 11 2022, 8:46 AM
delcypher accepted this revision.May 11 2022, 8:53 AM

@yaxunl Thanks for addressing my feedback so quickly. I think the commit message should also mention that KEYCUDA is now included in KEYALL. Other than that LGTM.

This revision is now accepted and ready to land.May 11 2022, 8:53 AM

@yaxunl Thanks for addressing my feedback so quickly. I think the commit message should also mention that KEYCUDA is now included in KEYALL. Other than that LGTM.

will do when committing

This revision was landed with ongoing or failed builds.May 11 2022, 11:29 AM
Closed by commit rG84db35594953: [clang] Fix KEYALL (authored by yaxunl). · Explain Why
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptMay 11 2022, 11:29 AM