This is an archive of the discontinued LLVM Phabricator instance.

Differential D125211

[flang] Fix windows bot after D125140
ClosedPublic

Authored by jeanPerier on May 9 2022, 1:29 AM.

Details

Reviewers
rovka
kiranchandramohan
peixin
schweitz
PeteSteinfeld
Commits
rGd38915ffebee: [flang] Fix windows bot after D125140
Summary

The ifdef is not required in the header, common::int128_t is always
defined. The function declaration must be available in lowering
regardless of the host int128_t support.

Diff Detail

Event Timeline

jeanPerier created this revision.May 9 2022, 1:29 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 9 2022, 1:29 AM
Herald added a subscriber: jdoerfert. · View Herald Transcript
jeanPerier requested review of this revision.May 9 2022, 1:29 AM
Harbormaster completed remote builds in B163435: Diff 428001.May 9 2022, 1:47 AM
jeanPerier added a reviewer: PeteSteinfeld.May 9 2022, 4:25 AM
kiranchandramohan accepted this revision.May 9 2022, 4:26 AM

LGTM.

This revision is now accepted and ready to land.May 9 2022, 4:26 AM
peixin accepted this revision.May 9 2022, 5:50 AM

LGTM

Closed by commit rGd38915ffebee: [flang] Fix windows bot after D125140 (authored by jeanPerier). · Explain WhyMay 9 2022, 6:24 AM
This revision was automatically updated to reflect the committed changes.
jeanPerier added a commit: rGd38915ffebee: [flang] Fix windows bot after D125140.

Revision Contents

PathSize
flang/
include/
flang/
Runtime/
2 lines

Diff 428063

flang/include/flang/Runtime/io-api.h

Show First 20 Lines • Show All 117 Lines • ▼ Show 20 Lines
// wide integer type can fit in a default integer. Since it should be called // wide integer type can fit in a default integer. Since it should be called
// before the BeginXXX(unit, ...) call, it has its own error handling interface. // before the BeginXXX(unit, ...) call, it has its own error handling interface.
// If handleError is false, and the unit number is out of range, the program // If handleError is false, and the unit number is out of range, the program
// will be terminated. Otherwise, if unit is out of range, a nonzero Iostat // will be terminated. Otherwise, if unit is out of range, a nonzero Iostat
// code is returned and ioMsg is set if it is not a nullptr. // code is returned and ioMsg is set if it is not a nullptr.
enum Iostat IONAME(CheckUnitNumberInRange64)(std::int64_t unit, enum Iostat IONAME(CheckUnitNumberInRange64)(std::int64_t unit,
bool handleError, char *ioMsg = nullptr, std::size_t ioMsgLength = 0, bool handleError, char *ioMsg = nullptr, std::size_t ioMsgLength = 0,
const char *sourceFile = nullptr, int sourceLine = 0); const char *sourceFile = nullptr, int sourceLine = 0);
#ifdef __SIZEOF_INT128__
enum Iostat IONAME(CheckUnitNumberInRange128)(common::int128_t unit, enum Iostat IONAME(CheckUnitNumberInRange128)(common::int128_t unit,
bool handleError, char *ioMsg = nullptr, std::size_t ioMsgLength = 0, bool handleError, char *ioMsg = nullptr, std::size_t ioMsgLength = 0,
const char *sourceFile = nullptr, int sourceLine = 0); const char *sourceFile = nullptr, int sourceLine = 0);
#endif
// External synchronous I/O initiation // External synchronous I/O initiation
Cookie IONAME(BeginExternalListOutput)(ExternalUnit = DefaultUnit, Cookie IONAME(BeginExternalListOutput)(ExternalUnit = DefaultUnit,
const char *sourceFile = nullptr, int sourceLine = 0); const char *sourceFile = nullptr, int sourceLine = 0);
Cookie IONAME(BeginExternalListInput)(ExternalUnit = DefaultUnit, Cookie IONAME(BeginExternalListInput)(ExternalUnit = DefaultUnit,
const char *sourceFile = nullptr, int sourceLine = 0); const char *sourceFile = nullptr, int sourceLine = 0);
Cookie IONAME(BeginExternalFormattedOutput)(const char *format, std::size_t, Cookie IONAME(BeginExternalFormattedOutput)(const char *format, std::size_t,
ExternalUnit = DefaultUnit, const char *sourceFile = nullptr, ExternalUnit = DefaultUnit, const char *sourceFile = nullptr,
▲ Show 20 Lines • Show All 204 Lines • Show Last 20 Lines