[github] format and refactor GitHub workflows

[VoltrexMaster]

Summary

Format the GitHub workflow files and refactor the scripts provided for consistency.

[VoltrexMaster]

Rebase and add upstream changes.

[tstellar]

This looks OK to me.

[asl]

.github/workflows/llvm-bugs.yml

37

Will you please keep vertical formatting here as it improves the readability!

Thanks!

[VoltrexMaster]

Keep vertical formatting in case of readability as suggested.

[VoltrexMaster]

Rebase and add upstream changes.

[VoltrexMaster]

Rebase and add upstream changes.

[VoltrexMaster]

@asl I've kept the vertical formatting as you suggested.

[asl]

Thanks!

.github/workflows/closed-issues.yml

 name: Labeling closed issues
 on:
   issues:
     types: ['closed']
 
 jobs:
   automate-issues-labels:
     runs-on: ubuntu-latest
     if: github.repository == 'llvm/llvm-project'
     steps:
       - uses: andymckay/labeler@1.0.4
         with:
-          remove-labels: "awaiting-review"
+          remove-labels: 'awaiting-review'
 

.github/workflows/issue-release-workflow.yml

 # This contains the workflow definitions that allow users to test backports
 # to the release branch using comments on issues.
 #
 # /cherry-pick <commit> <...>
 #
 # This comment will attempt to cherry-pick the given commits to the latest
-# release branch (release/Y.x) and if successful push the result to a branch
+# release branch (release/Y.x) and if successful, push the result to a branch
 # on github.
 #
 # /branch <owner>/<repo>/<branch>
 #
 # This comment will create a pull request from <branch> to the latest release
 # branch.
 
 name: Issue Release Workflow

 env:
   COMMENT_BODY: ${{ github.event.action == 'opened' && github.event.issue.body || github.event.comment.body  }}
 
 jobs:
   backport-commits:
     name: Backport Commits
     runs-on: ubuntu-20.04
     if: >-
-        (github.repository == 'llvm/llvm-project') &&
-        !startswith(github.event.comment.body, '<!--IGNORE-->') &&
-        contains(github.event.action == 'opened' && github.event.issue.body || github.event.comment.body, '/cherry-pick')
     steps:
       - name: Fetch LLVM sources
         uses: actions/checkout@v2
         with:
           repository: llvm/llvm-project
           # GitHub stores the token used for checkout and uses it for pushes
           # too, but we want to use a different token for pushing, so we need
           # to disable persist-credentials here.
steps:
           release-workflow \
           --issue-number ${{ github.event.issue.number }} \
           auto
 
   create-pull-request:
     name: Create Pull Request
     runs-on: ubuntu-20.04
     if: >-
-        (github.repository == 'llvm/llvm-project') &&
-        !startswith(github.event.comment.body, '<!--IGNORE-->') &&
-        contains(github.event.comment.body, '/branch')
 
     steps:
       - name: Fetch LLVM sources
         uses: actions/checkout@v2
 
       - name: Setup Environment
-        run:  |
+        run: |
           pip install -r ./llvm/utils/git/requirements.txt
 
       - name: Create Pull Request
         run: |
           printf "$COMMENT_BODY" |
           ./llvm/utils/git/github-automation.py \
           --repo $GITHUB_REPOSITORY \
           --token ${{ secrets.RELEASE_WORKFLOW_PUSH_SECRET }} \
           release-workflow \
           --issue-number ${{ github.event.issue.number }} \
           auto

.github/workflows/issue-subscriber.yml

 name: Issue Subscriber
 
 on:
   issues:
     types:
       - labeled
 
 jobs:
   auto-subscribe:
     runs-on: ubuntu-latest
     if: github.repository == 'llvm/llvm-project'
     steps:
       - name: Setup Automation Script
-      run:  |
+        run: |
           curl -O -L https://raw.githubusercontent.com/$GITHUB_REPOSITORY/$GITHUB_SHA/llvm/utils/git/github-automation.py
           curl -O -L https://raw.githubusercontent.com/$GITHUB_REPOSITORY/$GITHUB_SHA/llvm/utils/git/requirements.txt
           chmod a+x github-automation.py
           pip install -r requirements.txt
 
       - name: Update watchers
         # https://docs.github.com/en/actions/security-guides/security-hardening-for-github-actions#using-an-intermediate-environment-variable
         env:
           LABEL_NAME: ${{ github.event.label.name }}
         run: |
           ./github-automation.py \
             --token '${{ secrets.ISSUE_SUBSCRIBER_TOKEN }}' \
             issue-subscriber \
             --issue-number '${{ github.event.issue.number }}' \
             --label-name "$LABEL_NAME"

.github/workflows/llvm-bugs.yml

steps:
           node-version: 14
       - run: npm install mailgun.js form-data
       - name: Send notification
         uses: actions/github-script@v5
         env:
           MAILGUN_API_KEY: ${{ secrets.LLVM_BUGS_KEY }}
         with:
           script: |
-            const Mailgun = require("mailgun.js");
+            const Mailgun = require('mailgun.js');
             const formData = require('form-data');
-            const mailgun = new Mailgun(formData);
 
-            const DOMAIN = "email.llvm.org";
+            const mailgun = new Mailgun(formData);
+            const DOMAIN = 'email.llvm.org';
 
-            const mg = mailgun.client({username: 'api', key: process.env.MAILGUN_API_KEY});
+            const mg = mailgun.client({ username: 'api', key: process.env.MAILGUN_API_KEY });
 
             github.rest.issues.get({
               issue_number: context.issue.number,
               owner: context.repo.owner,
-              repo: context.repo.repo,
+              repo: context.repo.repo
             })
-            .then(function(issue) {
+            .then((issue) => {
               const payload = {
                 author : issue.data.user.login,
                 issue  : issue.data.number,
                 title  : issue.data.title,
                 url    : issue.data.html_url,
-                labels : issue.data.labels.map(label => { return label.name }),
-                assignee : issue.data.assignees.map(assignee => { return assignee.login }),
+                labels : issue.data.labels.map((label) => label.name),
+                assignee : issue.data.assignees.map((assignee) => assignee.login),
                 body   : issue.data.body
               };
-            
               const data = {
-                from: "LLVM Bugs <[e-mail]>",
-                to: "[e-mail]",
+                from: 'LLVM Bugs <[e-mail]>',
+                to: '[e-mail]',
                 subject: `[Bug ${issue.data.number}] ${issue.data.title}`,
-                template: "new-github-issue",
+                template: 'new-github-issue',
                 'o:tracking-clicks': 'no',
                 'h:X-Mailgun-Variables': JSON.stringify(payload)
               };
 
-              return mg.messages.create(DOMAIN, data)
+              return mg.messages.create(DOMAIN, data);
             })
-            .then(msg => console.log(msg));
+            .then((msg) => console.log(msg));

.github/workflows/new-issues.yml

 name: Labeling new issues
 on:
   issues:
     types: ['opened']
 
 jobs:
   automate-issues-labels:
     runs-on: ubuntu-latest
     if: github.repository == 'llvm/llvm-project'
     steps:
       - uses: andymckay/labeler@1.0.4
         with:
-          add-labels: "new issue"
+          add-labels: 'new issue'
           ignore-if-labeled: true