This is an archive of the discontinued LLVM Phabricator instance.

Paths

Table of Contentst

-
llvm/
-
include/llvm/Support/
-
llvm/
-
Support/
-
AArch64TargetParser.def
-
unittests/Support/
-
Support/
-
TargetParserTest.cpp

Differential D125191

[AArch64] Ampere1 does not support MTE
ClosedPublic

Authored by philipp.tomsich on May 8 2022, 12:49 PM.

Download Raw Diff

Details

Reviewers

kristof.beyls
dmgreen

Commits

rG91b24b018062: [AArch64] Ampere1 does not support MTE

Summary

The initial support for the Ampere1 mistakenly signalled support for
the MTE feature. However, the core does not include the optional MTE
functionality.

Update the target parser to not include MTE for Ampere1.

Diff Detail

Repository: rG LLVM Github Monorepo

Unit TestsFailed

	Time	Test
	60,060 ms	x64 debian > ThreadSanitizer-x86_64.ThreadSanitizer-x86_64::restore_stack.cpp
	60,040 ms	x64 debian > libFuzzer.libFuzzer::fuzzer-leak.test
	60,080 ms	x64 debian > libFuzzer.libFuzzer::large.test
	60,030 ms	x64 debian > libFuzzer.libFuzzer::value-profile-load.test

Event Timeline

philipp.tomsich created this revision.May 8 2022, 12:49 PM

Herald added a project: Restricted Project. · View Herald TranscriptMay 8 2022, 12:49 PM

Herald added a subscriber: kristof.beyls. · View Herald Transcript

philipp.tomsich requested review of this revision.May 8 2022, 12:49 PM

Herald added a project: Restricted Project. · View Herald TranscriptMay 8 2022, 12:49 PM

Herald added a subscriber: llvm-commits. · View Herald Transcript

Harbormaster completed remote builds in B163395: Diff 427952.May 8 2022, 1:23 PM

philipp.tomsich retitled this revision from [AArch64] Ampere1 des not support MTE to [AArch64] Ampere1 does not support MTE.May 8 2022, 1:41 PM

philipp.tomsich added reviewers: kristof.beyls, dmgreen.May 9 2022, 1:15 AM

Sounds good to me.

This revision is now accepted and ready to land.May 9 2022, 2:18 AM

This revision was landed with ongoing or failed builds.May 9 2022, 2:29 AM

Closed by commit rG91b24b018062: [AArch64] Ampere1 does not support MTE (authored by philipp.tomsich). · Explain Why

This revision was automatically updated to reflect the committed changes.

philipp.tomsich added a commit: rG91b24b018062: [AArch64] Ampere1 does not support MTE.

Doesn't it also need to be removed from the list in llvm/lib/Target/AArch64/AArch64.td?

Revision Contents

Path

Size

llvm/

include/

llvm/

Support/

AArch64TargetParser.def

3 lines

unittests/

Support/

TargetParserTest.cpp

2 lines

Diff 427952

llvm/include/llvm/Support/AArch64TargetParser.def

Show First 20 Lines • Show All 286 Lines • ▼ Show 20 Lines	AARCH64_CPU_NAME("tsv110", ARMV8_2A, FK_CRYPTO_NEON_FP_ARMV8, false,
(AArch64::AEK_DOTPROD \|		(AArch64::AEK_DOTPROD \|
AArch64::AEK_FP16 \| AArch64::AEK_FP16FML \|		AArch64::AEK_FP16 \| AArch64::AEK_FP16FML \|
AArch64::AEK_PROFILE))		AArch64::AEK_PROFILE))
AARCH64_CPU_NAME("a64fx", ARMV8_2A, FK_CRYPTO_NEON_FP_ARMV8, false,		AARCH64_CPU_NAME("a64fx", ARMV8_2A, FK_CRYPTO_NEON_FP_ARMV8, false,
(AArch64::AEK_FP16 \| AArch64::AEK_SVE))		(AArch64::AEK_FP16 \| AArch64::AEK_SVE))
AARCH64_CPU_NAME("carmel", ARMV8_2A, FK_CRYPTO_NEON_FP_ARMV8, false,		AARCH64_CPU_NAME("carmel", ARMV8_2A, FK_CRYPTO_NEON_FP_ARMV8, false,
AArch64::AEK_FP16)		AArch64::AEK_FP16)
AARCH64_CPU_NAME("ampere1", ARMV8_6A, FK_CRYPTO_NEON_FP_ARMV8, false,		AARCH64_CPU_NAME("ampere1", ARMV8_6A, FK_CRYPTO_NEON_FP_ARMV8, false,
(AArch64::AEK_FP16 \| AArch64::AEK_MTE \| AArch64::AEK_SB \|		(AArch64::AEK_FP16 \| AArch64::AEK_SB \| AArch64::AEK_SSBS))
AArch64::AEK_SSBS))
// Invalid CPU		// Invalid CPU
AARCH64_CPU_NAME("invalid", INVALID, FK_INVALID, true, AArch64::AEK_INVALID)		AARCH64_CPU_NAME("invalid", INVALID, FK_INVALID, true, AArch64::AEK_INVALID)
#undef AARCH64_CPU_NAME		#undef AARCH64_CPU_NAME

llvm/unittests/Support/TargetParserTest.cpp

Show First 20 Lines • Show All 1,195 Lines • ▼ Show 20 Lines	::testing::Values(
AArch64::AEK_BF16 \| AArch64::AEK_I8MM,		AArch64::AEK_BF16 \| AArch64::AEK_I8MM,
"8.5-A"),		"8.5-A"),
ARMCPUTestParams("ampere1", "armv8.6-a", "crypto-neon-fp-armv8",		ARMCPUTestParams("ampere1", "armv8.6-a", "crypto-neon-fp-armv8",
AArch64::AEK_CRC \| AArch64::AEK_FP \| AArch64::AEK_FP16 \|		AArch64::AEK_CRC \| AArch64::AEK_FP \| AArch64::AEK_FP16 \|
AArch64::AEK_SIMD \| AArch64::AEK_RAS \| AArch64::AEK_LSE \|		AArch64::AEK_SIMD \| AArch64::AEK_RAS \| AArch64::AEK_LSE \|
AArch64::AEK_RDM \| AArch64::AEK_RCPC \| AArch64::AEK_DOTPROD \|		AArch64::AEK_RDM \| AArch64::AEK_RCPC \| AArch64::AEK_DOTPROD \|
AArch64::AEK_SM4 \| AArch64::AEK_SHA3 \| AArch64::AEK_BF16 \|		AArch64::AEK_SM4 \| AArch64::AEK_SHA3 \| AArch64::AEK_BF16 \|
AArch64::AEK_SHA2 \| AArch64::AEK_AES \| AArch64::AEK_I8MM \|		AArch64::AEK_SHA2 \| AArch64::AEK_AES \| AArch64::AEK_I8MM \|
AArch64::AEK_MTE \| AArch64::AEK_SSBS \| AArch64::AEK_SB,		AArch64::AEK_SSBS \| AArch64::AEK_SB,
"8.6-A"),		"8.6-A"),
ARMCPUTestParams(		ARMCPUTestParams(
"neoverse-512tvb", "armv8.4-a", "crypto-neon-fp-armv8",		"neoverse-512tvb", "armv8.4-a", "crypto-neon-fp-armv8",
AArch64::AEK_RAS \| AArch64::AEK_SVE \| AArch64::AEK_SSBS \|		AArch64::AEK_RAS \| AArch64::AEK_SVE \| AArch64::AEK_SSBS \|
AArch64::AEK_RCPC \| AArch64::AEK_CRC \| AArch64::AEK_FP \|		AArch64::AEK_RCPC \| AArch64::AEK_CRC \| AArch64::AEK_FP \|
AArch64::AEK_SIMD \| AArch64::AEK_RAS \| AArch64::AEK_LSE \|		AArch64::AEK_SIMD \| AArch64::AEK_RAS \| AArch64::AEK_LSE \|
AArch64::AEK_RDM \| AArch64::AEK_RCPC \| AArch64::AEK_DOTPROD \|		AArch64::AEK_RDM \| AArch64::AEK_RCPC \| AArch64::AEK_DOTPROD \|
AArch64::AEK_CRYPTO \| AArch64::AEK_FP16 \| AArch64::AEK_BF16 \|		AArch64::AEK_CRYPTO \| AArch64::AEK_FP16 \| AArch64::AEK_BF16 \|
▲ Show 20 Lines • Show All 391 Lines • Show Last 20 Lines