Page MenuHomePhabricator
People philipp.tomsich

philipp.tomsich (Philipp Tomsich)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 11 2021, 11:25 AM (106 w, 7 h)

Recent Activity
View All

Fri, Feb 24

philipp.tomsich committed rGf68f04d07c69: [RISCV] Add vendor-defined XTheadCondMov (conditional move) extension (authored by philipp.tomsich).
[RISCV] Add vendor-defined XTheadCondMov (conditional move) extension
Fri, Feb 24, 12:41 PM · Restricted Project, Restricted Project
philipp.tomsich closed D144681: [RISCV] Add vendor-defined XTheadCondMov (conditional move) extension.
Fri, Feb 24, 12:41 PM · Restricted Project, Restricted Project
philipp.tomsich accepted D144700: [RISCV] Use ComplexPattern to reduce the number of patterns for XVentanaCondOps..

LGTM (beyond the judgement call on whether to keep the new complex pattern in XVentana.td or more it).

Fri, Feb 24, 6:19 AM · Restricted Project, Restricted Project
philipp.tomsich updated the diff for D144681: [RISCV] Add vendor-defined XTheadCondMov (conditional move) extension.
  • rebased on top of D144700
  • added plumbing for the ISel framework to commute operands, where legal
Fri, Feb 24, 6:17 AM · Restricted Project, Restricted Project

Thu, Feb 23

philipp.tomsich added inline comments to D144700: [RISCV] Use ComplexPattern to reduce the number of patterns for XVentanaCondOps..
Thu, Feb 23, 11:50 PM · Restricted Project, Restricted Project
philipp.tomsich added a comment to D144681: [RISCV] Add vendor-defined XTheadCondMov (conditional move) extension.
In D144681#4149472, @craig.topper wrote:

I just posted D144700 that can help reduce the number of patterns needed.

Thu, Feb 23, 11:47 PM · Restricted Project, Restricted Project
philipp.tomsich added inline comments to D144681: [RISCV] Add vendor-defined XTheadCondMov (conditional move) extension.
Thu, Feb 23, 11:46 PM · Restricted Project, Restricted Project
philipp.tomsich updated the diff for D144681: [RISCV] Add vendor-defined XTheadCondMov (conditional move) extension.
  • rebase after landing the MemIdx patches
Thu, Feb 23, 3:46 PM · Restricted Project, Restricted Project
philipp.tomsich committed rG7b79e8d45576: [RISCV] Add vendor-defined XTheadFMemIdx (FP Indexed Memory Operations)… (authored by mtsamis).
[RISCV] Add vendor-defined XTheadFMemIdx (FP Indexed Memory Operations)…
Thu, Feb 23, 3:36 PM · Restricted Project, Restricted Project
philipp.tomsich closed D144647: [RISCV] Add vendor-defined XTheadFMemIdx (FP Indexed Memory Operations) extension.
Thu, Feb 23, 3:35 PM · Restricted Project, Restricted Project
philipp.tomsich committed rGf6262201d8fd: [RISCV] Add vendor-defined XTheadMemIdx (Indexed Memory Operations) extension (authored by mtsamis).
[RISCV] Add vendor-defined XTheadMemIdx (Indexed Memory Operations) extension
Thu, Feb 23, 3:18 PM · Restricted Project, Restricted Project
philipp.tomsich closed D144249: [RISCV] Add vendor-defined XTheadMemIdx (Indexed Memory Operations) extension.
Thu, Feb 23, 3:18 PM · Restricted Project, Restricted Project
philipp.tomsich requested review of D144681: [RISCV] Add vendor-defined XTheadCondMov (conditional move) extension.
Thu, Feb 23, 3:01 PM · Restricted Project, Restricted Project

Wed, Feb 22

philipp.tomsich committed rGa6446668a339: [RISCV] XTHeadMemPair: Fix invalid mempair combine for types other than i32/i64 (authored by mtsamis).
[RISCV] XTHeadMemPair: Fix invalid mempair combine for types other than i32/i64
Wed, Feb 22, 10:58 AM · Restricted Project, Restricted Project
philipp.tomsich closed D144559: [RISCV] XTHeadMemPair: Fix invalid mempair combine for types other than i32/i64.
Wed, Feb 22, 10:57 AM · Restricted Project, Restricted Project
philipp.tomsich committed rG16a6cf6a99c2: [RISCV] Add vendor-defined XTheadSync (Multi-core synchronization) extension (authored by mtsamis).
[RISCV] Add vendor-defined XTheadSync (Multi-core synchronization) extension
Wed, Feb 22, 2:22 AM · Restricted Project, Restricted Project
philipp.tomsich closed D144501: [RISCV] Add vendor-defined XTheadSync (Multi-core synchronization) extension.
Wed, Feb 22, 2:21 AM · Restricted Project, Restricted Project
philipp.tomsich committed rGf5b484c56f7b: [RISCV] Add vendor-defined XTheadCmo (Cache Management Operations) extension (authored by mtsamis).
[RISCV] Add vendor-defined XTheadCmo (Cache Management Operations) extension
Wed, Feb 22, 1:58 AM · Restricted Project, Restricted Project
philipp.tomsich closed D144496: [RISCV] Add vendor-defined XTheadCmo (Cache Management Operations) extension.
Wed, Feb 22, 1:58 AM · Restricted Project, Restricted Project

Feb 21 2023

philipp.tomsich committed rGbbb58a2302c6: [RISCV] Add vendor-defined XTheadMemPair (two-GPR Memory Operations) extension (authored by mtsamis).
[RISCV] Add vendor-defined XTheadMemPair (two-GPR Memory Operations) extension
Feb 21 2023, 3:23 AM · Restricted Project, Restricted Project
philipp.tomsich closed D144002: [RISCV] Add vendor-defined XTheadMemPair (two-GPR Memory Operations) extension.
Feb 21 2023, 3:22 AM · Restricted Project, Restricted Project

Feb 17 2023

philipp.tomsich committed rG10b7cd660c73: [RISCV] Select signed and unsigned bitfield extracts for XTHeadBb (authored by philipp.tomsich).
[RISCV] Select signed and unsigned bitfield extracts for XTHeadBb
Feb 17 2023, 12:46 PM · Restricted Project, Restricted Project
philipp.tomsich closed D144229: [RISCV] Select signed and unsigned bitfield extracts for XTHeadBb.
Feb 17 2023, 12:46 PM · Restricted Project, Restricted Project
philipp.tomsich updated the diff for D144229: [RISCV] Select signed and unsigned bitfield extracts for XTHeadBb.
  • prefer SRLIW over TH.EXTU
Feb 17 2023, 11:56 AM · Restricted Project, Restricted Project
philipp.tomsich added inline comments to D144229: [RISCV] Select signed and unsigned bitfield extracts for XTHeadBb.
Feb 17 2023, 11:30 AM · Restricted Project, Restricted Project
philipp.tomsich added inline comments to D144229: [RISCV] Select signed and unsigned bitfield extracts for XTHeadBb.
Feb 17 2023, 11:18 AM · Restricted Project, Restricted Project
philipp.tomsich updated the diff for D144229: [RISCV] Select signed and unsigned bitfield extracts for XTHeadBb.
  • reject recognition of bitfield-extract if (shr (shl X c1) c2) has c1 > c2, which would leave the extracted bitfield at a bitposition > 0 (and turn the LSB negative...)
  • add test-coverage for this case
Feb 17 2023, 11:17 AM · Restricted Project, Restricted Project
philipp.tomsich reopened D143394: [RISCV] Add performMULcombine to perform strength-reduction.

Accidentially pushed (another 'arc patch' issue) and reverted.

Feb 17 2023, 10:47 AM · Restricted Project, Restricted Project
philipp.tomsich added a reverting change for rG20cc23c708f0: [RISCV] Add performMULcombine to perform strength-reduction: rGefe7c4b77bed: Revert "[RISCV] Add performMULcombine to perform strength-reduction".
Feb 17 2023, 10:47 AM · Restricted Project, Restricted Project
philipp.tomsich added a reverting change for D143394: [RISCV] Add performMULcombine to perform strength-reduction: rGefe7c4b77bed: Revert "[RISCV] Add performMULcombine to perform strength-reduction".
Feb 17 2023, 10:47 AM · Restricted Project, Restricted Project
philipp.tomsich committed rGefe7c4b77bed: Revert "[RISCV] Add performMULcombine to perform strength-reduction" (authored by philipp.tomsich).
Revert "[RISCV] Add performMULcombine to perform strength-reduction"
Feb 17 2023, 10:47 AM · Restricted Project, Restricted Project
philipp.tomsich reopened D144002: [RISCV] Add vendor-defined XTheadMemPair (two-GPR Memory Operations) extension.

Accidentially pushed and reverted.

Feb 17 2023, 10:47 AM · Restricted Project, Restricted Project
philipp.tomsich added a reverting change for D144002: [RISCV] Add vendor-defined XTheadMemPair (two-GPR Memory Operations) extension: rG16a66af0a0fe: Revert "[RISCV] Add vendor-defined XTheadMemPair (two-GPR Memory Operations)….
Feb 17 2023, 10:47 AM · Restricted Project, Restricted Project
philipp.tomsich added a reverting change for rGd2918544a7fc: [RISCV] Add vendor-defined XTheadMemPair (two-GPR Memory Operations) extension: rG16a66af0a0fe: Revert "[RISCV] Add vendor-defined XTheadMemPair (two-GPR Memory Operations)….
Feb 17 2023, 10:47 AM · Restricted Project, Restricted Project
philipp.tomsich committed rG16a66af0a0fe: Revert "[RISCV] Add vendor-defined XTheadMemPair (two-GPR Memory Operations)… (authored by philipp.tomsich).
Revert "[RISCV] Add vendor-defined XTheadMemPair (two-GPR Memory Operations)…
Feb 17 2023, 10:46 AM · Restricted Project, Restricted Project
philipp.tomsich committed rG6774ba841145: [RISCV] xtheadmac: fix commutativity issue for the in/out register (authored by mtsamis).
[RISCV] xtheadmac: fix commutativity issue for the in/out register
Feb 17 2023, 10:46 AM · Restricted Project, Restricted Project
philipp.tomsich committed rG20cc23c708f0: [RISCV] Add performMULcombine to perform strength-reduction (authored by philipp.tomsich).
[RISCV] Add performMULcombine to perform strength-reduction
Feb 17 2023, 10:46 AM · Restricted Project, Restricted Project
philipp.tomsich committed rGd2918544a7fc: [RISCV] Add vendor-defined XTheadMemPair (two-GPR Memory Operations) extension (authored by mtsamis).
[RISCV] Add vendor-defined XTheadMemPair (two-GPR Memory Operations) extension
Feb 17 2023, 10:46 AM · Restricted Project, Restricted Project
philipp.tomsich closed D144278: [RISCV] xtheadmac: fix commutativity issue for the in/out register.
Feb 17 2023, 10:45 AM · Restricted Project, Restricted Project
philipp.tomsich closed D143394: [RISCV] Add performMULcombine to perform strength-reduction.
Feb 17 2023, 10:45 AM · Restricted Project, Restricted Project
philipp.tomsich closed D144002: [RISCV] Add vendor-defined XTheadMemPair (two-GPR Memory Operations) extension.
Feb 17 2023, 10:45 AM · Restricted Project, Restricted Project
philipp.tomsich updated the diff for D144229: [RISCV] Select signed and unsigned bitfield extracts for XTHeadBb.
  • now depends on D144278 (commutativity fix for THeadMac)
  • updated test cases (for this dependency)
Feb 17 2023, 10:09 AM · Restricted Project, Restricted Project
philipp.tomsich requested review of D144278: [RISCV] xtheadmac: fix commutativity issue for the in/out register.
Feb 17 2023, 10:08 AM · Restricted Project, Restricted Project
philipp.tomsich updated the diff for D144229: [RISCV] Select signed and unsigned bitfield extracts for XTHeadBb.
  • fix (and X C1) cases for th.extu
    • don't use th.extu if andi can be used
    • ensure it is used for bitfield extractions starting at bit 0 (instead of falling back to (shr (shl X C1) C2))
Feb 17 2023, 5:29 AM · Restricted Project, Restricted Project

Feb 16 2023

philipp.tomsich requested review of D144229: [RISCV] Select signed and unsigned bitfield extracts for XTHeadBb.
Feb 16 2023, 3:42 PM · Restricted Project, Restricted Project

Feb 15 2023

philipp.tomsich added inline comments to D144002: [RISCV] Add vendor-defined XTheadMemPair (two-GPR Memory Operations) extension.
Feb 15 2023, 8:07 AM · Restricted Project, Restricted Project
philipp.tomsich added inline comments to D144002: [RISCV] Add vendor-defined XTheadMemPair (two-GPR Memory Operations) extension.
Feb 15 2023, 4:47 AM · Restricted Project, Restricted Project

Feb 14 2023

philipp.tomsich added inline comments to D144002: [RISCV] Add vendor-defined XTheadMemPair (two-GPR Memory Operations) extension.
Feb 14 2023, 2:49 PM · Restricted Project, Restricted Project
philipp.tomsich added inline comments to D144002: [RISCV] Add vendor-defined XTheadMemPair (two-GPR Memory Operations) extension.
Feb 14 2023, 2:23 PM · Restricted Project, Restricted Project
philipp.tomsich committed rG055cd78eef15: [RISCV] Untabify THMulAccumulate_rr. NFC. (authored by philipp.tomsich).
[RISCV] Untabify THMulAccumulate_rr. NFC.
Feb 14 2023, 11:29 AM · Restricted Project, Restricted Project
philipp.tomsich committed rGd4012bc43f9a: [RISCV] Add vendor-defined XTheadMAC (multiply-accumulate) extension (authored by mtsamis).
[RISCV] Add vendor-defined XTheadMAC (multiply-accumulate) extension
Feb 14 2023, 11:26 AM · Restricted Project, Restricted Project
philipp.tomsich closed D143847: [RISCV] Add vendor-defined XTheadMAC (multiply-accumulate) extension.
Feb 14 2023, 11:26 AM · Restricted Project, Restricted Project
philipp.tomsich updated the diff for D143847: [RISCV] Add vendor-defined XTheadMAC (multiply-accumulate) extension.
  • introduce sexti16 as a complex pattern (matches values that are sign-extended to an i16 and returns the underlying node --- i.e, what is being fed into the sign-extension)
  • refactors sexti32 to share implementation with sexti16 (similarily to what is implemented for zexti32)
  • simplifies XTHeadMac implementation by matching sexti16 instead of having multiple cases spelled out for shl+sra and sext_inreg
Feb 14 2023, 3:50 AM · Restricted Project, Restricted Project

Feb 13 2023

philipp.tomsich planned changes to D143847: [RISCV] Add vendor-defined XTheadMAC (multiply-accumulate) extension.

We plan to have a major rework tomorrow:

  • introduce a sexti16 complex pattern
  • reduce the number of individual patterns (handling the sext_inreg and shl+sra case together)
Feb 13 2023, 2:20 PM · Restricted Project, Restricted Project
philipp.tomsich updated the diff for D143847: [RISCV] Add vendor-defined XTheadMAC (multiply-accumulate) extension.
  • update comment to not refer to sext_inreg
Feb 13 2023, 12:29 PM · Restricted Project, Restricted Project
philipp.tomsich updated the diff for D143847: [RISCV] Add vendor-defined XTheadMAC (multiply-accumulate) extension.
  • rework for review comments
Feb 13 2023, 12:11 PM · Restricted Project, Restricted Project
philipp.tomsich committed rG1232b9d47209: [RISCV] Fix -Wbraced-scalar-init warning. NFC (authored by philipp.tomsich).
[RISCV] Fix -Wbraced-scalar-init warning. NFC
Feb 13 2023, 8:57 AM · Restricted Project, Restricted Project
philipp.tomsich added inline comments to D143439: [RISCV] Add vendor-defined XTheadBb (basic bit-manipulation) extension.
Feb 13 2023, 8:53 AM · Restricted Project, Restricted Project, Restricted Project
philipp.tomsich committed rGfc02eeb24fc0: [RISCV] Add vendor-defined XTheadBb (basic bit-manipulation) extension (authored by philipp.tomsich).
[RISCV] Add vendor-defined XTheadBb (basic bit-manipulation) extension
Feb 13 2023, 8:02 AM · Restricted Project, Restricted Project, Restricted Project
philipp.tomsich closed D143439: [RISCV] Add vendor-defined XTheadBb (basic bit-manipulation) extension.
Feb 13 2023, 8:02 AM · Restricted Project, Restricted Project, Restricted Project
philipp.tomsich committed rG04a2baf58f23: [RISCV] Add vendor-defined XTHeadBs (single-bit) extension (authored by philipp.tomsich).
[RISCV] Add vendor-defined XTHeadBs (single-bit) extension
Feb 13 2023, 7:28 AM · Restricted Project, Restricted Project
philipp.tomsich closed D143036: [RISCV] Add vendor-defined XTHeadBs (single-bit) extension.
Feb 13 2023, 7:28 AM · Restricted Project, Restricted Project

Feb 12 2023

philipp.tomsich requested review of D143847: [RISCV] Add vendor-defined XTheadMAC (multiply-accumulate) extension.
Feb 12 2023, 9:18 AM · Restricted Project, Restricted Project
philipp.tomsich updated the diff for D143439: [RISCV] Add vendor-defined XTheadBb (basic bit-manipulation) extension.
  • updated for review comments
  • added release not entry
  • added missing test in attributes.ll
Feb 12 2023, 9:16 AM · Restricted Project, Restricted Project, Restricted Project
philipp.tomsich updated the diff for D143036: [RISCV] Add vendor-defined XTHeadBs (single-bit) extension.
  • merged HasBitTest tests
Feb 12 2023, 9:15 AM · Restricted Project, Restricted Project

Feb 11 2023

philipp.tomsich updated the summary of D143036: [RISCV] Add vendor-defined XTHeadBs (single-bit) extension.
Feb 11 2023, 1:00 AM · Restricted Project, Restricted Project

Feb 8 2023

philipp.tomsich planned changes to D143394: [RISCV] Add performMULcombine to perform strength-reduction.

I'll take the two suggestions (Kito and Philip) on getting Zba supported in this initial change as a hint that there's no point in delaying this.
We'll get a new version ready that adds the following:

  • enables for Zba
Feb 8 2023, 7:44 AM · Restricted Project, Restricted Project

Feb 7 2023

philipp.tomsich reopened D143439: [RISCV] Add vendor-defined XTheadBb (basic bit-manipulation) extension.

Reopening as this was accidentially pushed and reverted when doing 'arc patch on D143534'.

Feb 7 2023, 11:05 PM · Restricted Project, Restricted Project, Restricted Project
philipp.tomsich reopened D143036: [RISCV] Add vendor-defined XTHeadBs (single-bit) extension.

Reopening as this was accidentially pushed and reverted when doing 'arc patch on D143534'.

Feb 7 2023, 11:04 PM · Restricted Project, Restricted Project
philipp.tomsich reopened D143394: [RISCV] Add performMULcombine to perform strength-reduction.

Reopening as this was accidentially pushed and revert using 'arc patch on D143534'.

Feb 7 2023, 11:03 PM · Restricted Project, Restricted Project
philipp.tomsich added a reverting change for rG3304d51b676e: [RISCV] Add performMULcombine to perform strength-reduction: rGb4431b2d945b: Revert "[RISCV] Add performMULcombine to perform strength-reduction".
Feb 7 2023, 11:01 PM · Restricted Project, Restricted Project
philipp.tomsich committed rGb4431b2d945b: Revert "[RISCV] Add performMULcombine to perform strength-reduction" (authored by philipp.tomsich).
Revert "[RISCV] Add performMULcombine to perform strength-reduction"
Feb 7 2023, 11:01 PM · Restricted Project, Restricted Project
philipp.tomsich added a reverting change for rG656188ddc407: [RISCV] Add vendor-defined XTHeadBs (single-bit) extension: rG0bda19928595: Revert "[RISCV] Add vendor-defined XTHeadBs (single-bit) extension".
Feb 7 2023, 11:01 PM · Restricted Project, Restricted Project
philipp.tomsich committed rG0bda19928595: Revert "[RISCV] Add vendor-defined XTHeadBs (single-bit) extension" (authored by philipp.tomsich).
Revert "[RISCV] Add vendor-defined XTHeadBs (single-bit) extension"
Feb 7 2023, 11:01 PM · Restricted Project, Restricted Project
philipp.tomsich added a reverting change for D143394: [RISCV] Add performMULcombine to perform strength-reduction: rGb4431b2d945b: Revert "[RISCV] Add performMULcombine to perform strength-reduction".
Feb 7 2023, 11:01 PM · Restricted Project, Restricted Project
philipp.tomsich added a reverting change for rG19a59099095b: [RISCV] Add vendor-defined XTheadBb (basic bit-manipulation) extension: rGb0c3132226d5: Revert "[RISCV] Add vendor-defined XTheadBb (basic bit-manipulation) extension".
Feb 7 2023, 11:01 PM · Restricted Project, Restricted Project, Restricted Project
philipp.tomsich committed rGb0c3132226d5: Revert "[RISCV] Add vendor-defined XTheadBb (basic bit-manipulation) extension" (authored by philipp.tomsich).
Revert "[RISCV] Add vendor-defined XTheadBb (basic bit-manipulation) extension"
Feb 7 2023, 11:01 PM · Restricted Project, Restricted Project, Restricted Project
philipp.tomsich added a reverting change for D143036: [RISCV] Add vendor-defined XTHeadBs (single-bit) extension: rG0bda19928595: Revert "[RISCV] Add vendor-defined XTHeadBs (single-bit) extension".
Feb 7 2023, 11:01 PM · Restricted Project, Restricted Project
philipp.tomsich added a reverting change for D143439: [RISCV] Add vendor-defined XTheadBb (basic bit-manipulation) extension: rGb0c3132226d5: Revert "[RISCV] Add vendor-defined XTheadBb (basic bit-manipulation) extension".
Feb 7 2023, 11:01 PM · Restricted Project, Restricted Project, Restricted Project
philipp.tomsich committed rG94888161c7d9: [RISCV] Fix comment for Zba tests. NFC. (authored by philipp.tomsich).
[RISCV] Fix comment for Zba tests. NFC.
Feb 7 2023, 10:58 PM · Restricted Project, Restricted Project
philipp.tomsich committed rG19a59099095b: [RISCV] Add vendor-defined XTheadBb (basic bit-manipulation) extension (authored by philipp.tomsich).
[RISCV] Add vendor-defined XTheadBb (basic bit-manipulation) extension
Feb 7 2023, 10:58 PM · Restricted Project, Restricted Project, Restricted Project
philipp.tomsich committed rG656188ddc407: [RISCV] Add vendor-defined XTHeadBs (single-bit) extension (authored by philipp.tomsich).
[RISCV] Add vendor-defined XTHeadBs (single-bit) extension
Feb 7 2023, 10:58 PM · Restricted Project, Restricted Project
philipp.tomsich committed rG3304d51b676e: [RISCV] Add performMULcombine to perform strength-reduction (authored by philipp.tomsich).
[RISCV] Add performMULcombine to perform strength-reduction
Feb 7 2023, 10:58 PM · Restricted Project, Restricted Project
philipp.tomsich closed D143534: [RISCV] Fix comment for Zba tests. NFC..
Feb 7 2023, 10:57 PM · Restricted Project, Restricted Project
philipp.tomsich closed D143439: [RISCV] Add vendor-defined XTheadBb (basic bit-manipulation) extension.
Feb 7 2023, 10:57 PM · Restricted Project, Restricted Project, Restricted Project
philipp.tomsich closed D143036: [RISCV] Add vendor-defined XTHeadBs (single-bit) extension.
Feb 7 2023, 10:57 PM · Restricted Project, Restricted Project
philipp.tomsich closed D143394: [RISCV] Add performMULcombine to perform strength-reduction.
Feb 7 2023, 10:57 PM · Restricted Project, Restricted Project
philipp.tomsich committed rGe25b30d90a69: [RISCV] Add vendor-defined XTHeadBa (address-generation) extension (authored by philipp.tomsich).
[RISCV] Add vendor-defined XTHeadBa (address-generation) extension
Feb 7 2023, 10:55 PM · Restricted Project, Restricted Project
philipp.tomsich closed D143029: [RISCV] Add vendor-defined XTHeadBa (address-generation) extension.
Feb 7 2023, 10:55 PM · Restricted Project, Restricted Project
philipp.tomsich updated the diff for D143029: [RISCV] Add vendor-defined XTHeadBa (address-generation) extension.
  • fixes comment in XTHeadBa-valid.s ("bitmanip base" -> XTHeadBa)
Feb 7 2023, 4:03 PM · Restricted Project, Restricted Project
philipp.tomsich requested review of D143534: [RISCV] Fix comment for Zba tests. NFC..
Feb 7 2023, 4:01 PM · Restricted Project, Restricted Project
philipp.tomsich added inline comments to D143439: [RISCV] Add vendor-defined XTheadBb (basic bit-manipulation) extension.
Feb 7 2023, 10:22 AM · Restricted Project, Restricted Project, Restricted Project
philipp.tomsich added inline comments to D143029: [RISCV] Add vendor-defined XTHeadBa (address-generation) extension.
Feb 7 2023, 10:18 AM · Restricted Project, Restricted Project
philipp.tomsich updated the diff for D143439: [RISCV] Add vendor-defined XTheadBb (basic bit-manipulation) extension.
  • rebase and update RISCVDisassembler.cc
Feb 7 2023, 5:16 AM · Restricted Project, Restricted Project, Restricted Project
philipp.tomsich updated the diff for D143036: [RISCV] Add vendor-defined XTHeadBs (single-bit) extension.
  • address Craig's review comments (style, NULL->nullptr and 2 variable shift paths)
Feb 7 2023, 5:14 AM · Restricted Project, Restricted Project
philipp.tomsich added inline comments to D143394: [RISCV] Add performMULcombine to perform strength-reduction.
Feb 7 2023, 5:13 AM · Restricted Project, Restricted Project
philipp.tomsich updated the diff for D143394: [RISCV] Add performMULcombine to perform strength-reduction.
  • don't try to handle vectors (yet)
  • unconditionally insert ANY_EXTEND and TRUNCATE and let later passes clean up
Feb 7 2023, 5:13 AM · Restricted Project, Restricted Project
philipp.tomsich added inline comments to D143029: [RISCV] Add vendor-defined XTHeadBa (address-generation) extension.
Feb 7 2023, 5:10 AM · Restricted Project, Restricted Project
philipp.tomsich updated the diff for D143029: [RISCV] Add vendor-defined XTHeadBa (address-generation) extension.
  • rebased and updated RISCVDisassembler.cpp
  • merged RV32 and RV64 assembler tests into a single file
Feb 7 2023, 5:08 AM · Restricted Project, Restricted Project

Feb 6 2023

philipp.tomsich updated the summary of D143036: [RISCV] Add vendor-defined XTHeadBs (single-bit) extension.
Feb 6 2023, 3:44 PM · Restricted Project, Restricted Project