Details
Details
- Reviewers
rriddle
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
This patch doesn't look correct. This is just going to lead to an assert/crash in the other code path, the else branch there doesn't have any support for tensor or complex.
Comment Actions
I expected this to Just Work, since it seems like it did before 0d5caa8, and because RankedTensorType and ComplexType just have arrays as storage types, same as DenseElementsAttr, but I'm not familiar with the invariant relevant to this bit of code.
AFAICT there aren't any failing assertions in the else branch; was able to use this to successfully construct a DEA of complex<f32>.
(hadn't meant to send this out for review just yet without checking in the tests; I think I misunderstood the cl2git flags)