Page MenuHomePhabricator

atondwal (Anish Tondwalkar)
User

Projects

User does not belong to any projects.

User Details

User Since
May 6 2022, 9:12 PM (8 w, 1 d)

Recent Activity

May 7 2022

atondwal added a comment to D125155: [mlir][DenseElementsAttr] ::get for Tensor and Complex.

I expected this to Just Work, since it seems like it did before 0d5caa8, and because RankedTensorType and ComplexType just have arrays as storage types, same as DenseElementsAttr, but I'm not familiar with the invariant relevant to this bit of code.
AFAICT there aren't any failing assertions in the else branch; was able to use this to successfully construct a DEA of complex<f32>.
(hadn't meant to send this out for review just yet without checking in the tests; I think I misunderstood the cl2git flags)

May 7 2022, 2:12 AM · Restricted Project, Restricted Project

May 6 2022

atondwal requested review of D125155: [mlir][DenseElementsAttr] ::get for Tensor and Complex.
May 6 2022, 9:27 PM · Restricted Project, Restricted Project