[libc] Add LINK_LIBRARIES option to add_fp_unittest and add_libc_unittest.

[lntue]

Summary

This is needed to prepare for adding FLAGS option.

[sivachandra]

libc/cmake/modules/LLVMLibCTestRules.cmake

149–150

Add a comment explaining why its a PREPEND here and an APPEND down below.

[lntue]

Address comments.

libc/cmake/modules/LLVMLibCTestRules.cmake

 # Usage
 #    add_libc_unittest(
 #      <target name>
 #      SUITE <name of the suite this test belongs to>
 #      SRCS  <list of .cpp files for the test>
 #      HDRS  <list of .h files for the test>
 #      DEPENDS <list of dependencies>
 #      COMPILE_OPTIONS <list of special compile options for this target>
-#      LINK_OPTIONS <list of special linking options for this target>
+#      LINK_LIBRARIES <list of linking libraries for this target>
 #    )
 function(add_libc_unittest target_name)
   if(NOT LLVM_INCLUDE_TESTS)
     return()
   endif()
 
   cmake_parse_arguments(
     "LIBC_UNITTEST"
-    "NO_RUN_POSTBUILD" # Optional arguments
+    "NO_RUN_POSTBUILD;NO_LIBC_UNITTEST_TEST_MAIN" # Optional arguments
     "SUITE;CXX_STANDARD" # Single value arguments
-    "SRCS;HDRS;DEPENDS;COMPILE_OPTIONS;LINK_OPTIONS" # Multi-value arguments
-    "NO_LIBC_UNITTEST_TEST_MAIN"
+    "SRCS;HDRS;DEPENDS;COMPILE_OPTIONS;LINK_LIBRARIES" # Multi-value arguments
     ${ARGN}
   )
   if(NOT LIBC_UNITTEST_SRCS)
     message(FATAL_ERROR "'add_libc_unittest' target requires a SRCS list of .cpp "
                         "files.")
   endif()
   if(NOT LIBC_UNITTEST_DEPENDS)
     message(FATAL_ERROR "'add_libc_unittest' target requires a DEPENDS list of "
function(add_libc_unittest target_name)
   if(LIBC_UNITTEST_CXX_STANDARD)
     set_target_properties(
       ${fq_target_name}
       PROPERTIES
         CXX_STANDARD ${LIBC_UNITTEST_CXX_STANDARD}
     )
   endif()
 
-  target_link_libraries(${fq_target_name} PRIVATE ${link_object_files})
-  if(LIBC_UNITTEST_LINK_OPTIONS)
-    target_link_options(
-      ${fq_target_name}
-      PRIVATE ${LIBC_UNITTEST_LINK_OPTIONS}
-    )
-  endif()
+  # Test object files will depend on LINK_LIBRARIES passed down from `add_fp_unittest`
+  list(PREPEND LIBC_UNITTEST_LINK_LIBRARIES ${link_object_files})
 
   set_target_properties(${fq_target_name}
     PROPERTIES RUNTIME_OUTPUT_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR})
 
   add_dependencies(
     ${fq_target_name}
     ${fq_deps_list}
   )
 
+  # LibcUnitTest and libc_test_utils should not depend on anything in LINK_LIBRARIES.
   if(NO_LIBC_UNITTEST_TEST_MAIN)
-    target_link_libraries(${fq_target_name} PRIVATE LibcUnitTest libc_test_utils)
+    list(APPEND LIBC_UNITTEST_LINK_LIBRARIES LibcUnitTest libc_test_utils)
   else()
-    target_link_libraries(${fq_target_name} PRIVATE LibcUnitTest LibcUnitTestMain libc_test_utils)
+    list(APPEND LIBC_UNITTEST_LINK_LIBRARIES LibcUnitTest LibcUnitTestMain libc_test_utils)
   endif()
 
+  target_link_libraries(${fq_target_name} PRIVATE ${LIBC_UNITTEST_LINK_LIBRARIES})
+
   if(NOT LIBC_UNITTEST_NO_RUN_POSTBUILD)
     add_custom_command(
       TARGET ${fq_target_name}
       POST_BUILD
       COMMAND $<TARGET_FILE:${fq_target_name}>
     )
   endif()
 

libc/test/src/CMakeLists.txt

 function(add_fp_unittest name)
   cmake_parse_arguments(
     "MATH_UNITTEST"
     "NEED_MPFR" # Optional arguments
     "" # Single value arguments
-    "" # Multi-value arguments
+    "LINK_LIBRARIES" # Multi-value arguments
     ${ARGN}
   )
 
   if(MATH_UNITTEST_NEED_MPFR)
     if(NOT LIBC_TESTS_CAN_USE_MPFR)
       message("WARNING: Math test ${name} will be skipped as MPFR library is not available.")
       return()
     endif()
   endif()
 
-  add_libc_unittest(${name} ${MATH_UNITTEST_UNPARSED_ARGUMENTS})
-  get_fq_target_name(${name} fq_target_name)
-  if (NOT TARGET ${fq_target_name})
-    return()
-  endif()
   if(MATH_UNITTEST_NEED_MPFR)
-    target_link_libraries(${fq_target_name} PRIVATE libcMPFRWrapper -lmpfr -lgmp)
+    list(APPEND MATH_UNITTEST_LINK_LIBRARIES libcMPFRWrapper -lmpfr -lgmp)
   endif()
-  target_link_libraries(${fq_target_name} PRIVATE LibcFPTestHelpers)
+  list(APPEND MATH_UNITTEST_LINK_LIBRARIES LibcFPTestHelpers)
+
+  add_libc_unittest(
+    ${name}
+    "${MATH_UNITTEST_UNPARSED_ARGUMENTS}"
+    LINK_LIBRARIES "${MATH_UNITTEST_LINK_LIBRARIES}"
+  )
 endfunction(add_fp_unittest)
 
 add_subdirectory(__support)
 add_subdirectory(ctype)
 add_subdirectory(errno)
 add_subdirectory(fenv)
 add_subdirectory(inttypes)
 add_subdirectory(math)

libc/test/src/__support/File/CMakeLists.txt

SUITE
     libc_support_unittests
   SRCS
     file_test.cpp
   DEPENDS
     libc.include.errno
     libc.include.stdio
     libc.include.stdlib
     libc.src.__support.File.file
-)
-
-target_link_libraries(
-  libc.test.src.__support.File.file_test PRIVATE LibcMemoryHelpers
+  LINK_LIBRARIES
+    LibcMemoryHelpers
 )
 
 if (TARGET libc.src.__support.File.platform_file)
   add_libc_unittest(
     platform_file_test
     SUITE
       libc_support_unittests
     SRCS

libc/test/src/math/exhaustive/CMakeLists.txt

SUITE
     libc_math_exhaustive_tests
   SRCS
     expf_test.cpp
   DEPENDS
     .exhaustive_test
     libc.include.math
     libc.src.math.expf
     libc.src.__support.FPUtil.fputil
-  LINK_OPTIONS
+  LINK_LIBRARIES
     -lpthread
 )
 
 add_fp_unittest(
   exp2f_test
   NO_RUN_POSTBUILD
   NEED_MPFR
   SUITE
     libc_math_exhaustive_tests
   SRCS
     exp2f_test.cpp
   DEPENDS
     .exhaustive_test
     libc.include.math
     libc.src.math.exp2f
     libc.src.__support.FPUtil.fputil
-  LINK_OPTIONS
+  LINK_LIBRARIES
     -lpthread
 )
 
 add_fp_unittest(
   expm1f_test
   NO_RUN_POSTBUILD
   NEED_MPFR
   SUITE
     libc_math_exhaustive_tests
   SRCS
     expm1f_test.cpp
   DEPENDS
     .exhaustive_test
     libc.include.math
     libc.src.math.expf
     libc.src.math.expm1f
     libc.src.__support.FPUtil.fputil
-  LINK_OPTIONS
+  LINK_LIBRARIES
     -lpthread
 )
 
 add_fp_unittest(
   logf_test
   NO_RUN_POSTBUILD
   NEED_MPFR
   SUITE
     libc_math_exhaustive_tests
   SRCS
     logf_test.cpp
   DEPENDS
     .exhaustive_test
     libc.include.math
     libc.src.math.logf
     libc.src.__support.FPUtil.fputil
-  LINK_OPTIONS
+  LINK_LIBRARIES
     -lpthread
 )
 
 add_fp_unittest(
   log10f_test
   NO_RUN_POSTBUILD
   NEED_MPFR
   SUITE
     libc_math_exhaustive_tests
   SRCS
     log10f_test.cpp
   DEPENDS
     .exhaustive_test
     libc.include.math
     libc.src.math.log10f
     libc.src.__support.FPUtil.fputil
-  LINK_OPTIONS
+  LINK_LIBRARIES
     -lpthread
 )
 
 add_fp_unittest(
   log1pf_test
   NO_RUN_POSTBUILD
   NEED_MPFR
   SUITE
     libc_math_exhaustive_tests
   SRCS
     log1pf_test.cpp
   DEPENDS
     .exhaustive_test
     libc.include.math
     libc.src.math.log1pf
     libc.src.__support.FPUtil.fputil
-  LINK_OPTIONS
+  LINK_LIBRARIES
     -lpthread
 )
 
 add_fp_unittest(
   log2f_test
   NO_RUN_POSTBUILD
   NEED_MPFR
   SUITE
     libc_math_exhaustive_tests
   SRCS
     log2f_test.cpp
   DEPENDS
     .exhaustive_test
     libc.include.math
     libc.src.math.log2f
     libc.src.__support.FPUtil.fputil
-  LINK_OPTIONS
+  LINK_LIBRARIES
     -lpthread
 )
 
 add_fp_unittest(
   hypotf_test
   NO_RUN_POSTBUILD
   NEED_MPFR
   SUITE
     libc_math_exhaustive_tests
   SRCS
     hypotf_test.cpp
   DEPENDS
     .exhaustive_test
     libc.include.math
     libc.src.math.hypotf
     libc.src.__support.FPUtil.fputil
   COMPILE_OPTIONS
     -O3
-  LINK_OPTIONS
+  LINK_LIBRARIES
     -lpthread
 )

libc/test/src/stdio/CMakeLists.txt

DEPENDS
     libc.src.stdio.fclose
     libc.src.stdio.feof
     libc.src.stdio.ferror
     libc.src.stdio.fflush
     libc.src.stdio.fopencookie
     libc.src.stdio.fread
     libc.src.stdio.fseek
     libc.src.stdio.fwrite
+  LINK_LIBRARIES
+    LibcMemoryHelpers
 )
 
-if(TARGET libc.test.src.stdio.fopencookie_test)
-  target_link_libraries(
-    libc.test.src.stdio.fopencookie_test PRIVATE LibcMemoryHelpers
-  )
-endif()
-
 add_subdirectory(printf_core)
 
 add_subdirectory(testdata)

libc/test/src/stdio/printf_core/CMakeLists.txt

 add_libc_unittest(
   parser_test
   SUITE
     libc_stdio_unittests
   SRCS
     parser_test.cpp
   DEPENDS
     libc.src.stdio.printf_core.parser
     libc.src.__support.arg_list
+  LINK_LIBRARIES
+    LibcPrintfHelpers
 )
 
-target_link_libraries(libc.test.src.stdio.printf_core.parser_test PRIVATE LibcPrintfHelpers)
-
 add_libc_unittest(
   string_writer_test
   SUITE
     libc_stdio_unittests
   SRCS
     string_writer_test.cpp
   DEPENDS
     libc.src.stdio.printf_core.writer
     libc.src.stdio.printf_core.string_writer
 )

libc/test/src/string/CMakeLists.txt

if(can_run)
       add_libc_unittest(
         ${fq_config_name}_test
         SUITE
           libc_string_unittests
         DEPENDS
           ${fq_config_name}
         COMPILE_OPTIONS
           ${LIBC_COMPILE_OPTIONS_NATIVE}
+        LINK_LIBRARIES
+          LibcMemoryHelpers
         ${ARGN}
       )
       get_fq_target_name(${fq_config_name}_test fq_target_name)
-      target_link_libraries(${fq_target_name} PRIVATE LibcMemoryHelpers)
     else()
       message(STATUS "Skipping test for '${fq_config_name}' insufficient host cpu features '${required_cpu_features}'")
     endif()
   endforeach()
 endfunction()
 
 add_libc_multi_impl_test(bcmp SRCS bcmp_test.cpp)
 add_libc_multi_impl_test(bzero SRCS bzero_test.cpp)
 add_libc_multi_impl_test(memcmp SRCS memcmp_test.cpp)
 add_libc_multi_impl_test(memcpy SRCS memcpy_test.cpp)
 add_libc_multi_impl_test(memmove SRCS memmove_test.cpp)
 add_libc_multi_impl_test(memset SRCS memset_test.cpp)