This is an archive of the discontinued LLVM Phabricator instance.

[X86] Set MaxVectorAlign for non-Darwin targets as well.
AcceptedPublic

Authored by ab on Aug 31 2015, 4:00 PM.

Details

Reviewers
echristo
rnk
Summary

Follow-up to r246229: this isn't Darwin-specific, so let's enable it for all X86 targets.

Quoting r160209, which introduced it:

Currently, if no aligned attribute is specified the alignment of a vector is inferred from its size.  Thus, very large vectors will be over-aligned with no benefit.

I tried to cc people for the various OSes we support; if you object or can suggest other reviewers, please do!

Diff Detail

Event Timeline

ab updated this revision to Diff 33641.Aug 31 2015, 4:00 PM
ab retitled this revision from to [X86] Set MaxVectorAlign for non-Darwin targets as well..
ab updated this object.
ab added reviewers: echristo, rnk.
ab added subscribers: alexr, dim, dschuff and 2 others.
echristo accepted this revision.Sep 9 2015, 3:00 PM
echristo edited edge metadata.

This seems reasonable to me, I can't see why it wouldn't be ok.

Thanks!

-eric

This revision is now accepted and ready to land.Sep 9 2015, 3:00 PM

(This ACK btw means "yes we should do this on all platforms", not that it's necessarily safe on any platform, see my mail on the original thread).

-eric

Looks like patch was not committed.

test/CodeGen/const-init.c