Page MenuHomePhabricator

alexr (Alex Rosenberg)
Manager, Platform Architecture, Sony Computer Entertainment Worldwide Studios

Projects

User does not belong to any projects.

User Details

User Since
Jul 9 2012, 4:04 PM (422 w, 1 d)

Recent Activity

Jan 8 2020

alexr added a comment to D72406: [Orc][LLJIT] Add optimizer support to LLJIT.

Seems simple enough, but Lang should weigh in.

Jan 8 2020, 11:36 AM · Restricted Project

Sep 2 2019

alexr committed rL370696: Request commit access for alexr.
Request commit access for alexr
Sep 2 2019, 10:04 PM

Apr 8 2016

alexr added a comment to D17741: adds __FILE_BASENAME__ builtin macro.

There are multiple features in this patch that should be considered separately. Please split the patch.

Apr 8 2016, 11:46 AM

Oct 1 2015

alexr added a comment to D11908: Clang support for -fthinlto..

I realize that we've all been referring to this as ThinLTO, but is that necessarily descriptive for users? What about inlineonly or something similar?

Oct 1 2015, 2:03 PM
alexr added a comment to D13351: [Power PC] add soft float support for ppc32.

PowerPC has floating point hardware by definition. Is this some new variant?

Oct 1 2015, 2:00 PM

Sep 10 2015

alexr added a comment to D12618: Reserve a vendor reserved block ID for bitcode.

So, we went through this last year.... http://lists.llvm.org/pipermail/llvm-dev/2014-November/078498.html

Sep 10 2015, 7:47 PM

Aug 26 2015

alexr committed rL246141: Whoops, remove trailing whitespace..
Whoops, remove trailing whitespace.
Aug 26 2015, 10:38 PM

Aug 25 2015

alexr committed rL246018: Modernize with range-based for loops..
Modernize with range-based for loops.
Aug 25 2015, 11:12 PM
alexr committed rL246017: Reduce code duplication..
Reduce code duplication.
Aug 25 2015, 11:12 PM
alexr committed rL246016: Trailing whitespace.
Trailing whitespace
Aug 25 2015, 11:12 PM

Aug 20 2015

alexr added a comment to D12139: Add 'strlen' formation to LoopIdiomRecognize.

This makes me very nervous. We have fielded a lot of user complaints about canonicalizing loops into memcpy calls. strlen feels like a more dubious choice.

Aug 20 2015, 1:31 PM

Aug 17 2015

alexr added a comment to D11944: Nativize filename in FileManager::getFile()..

Just to remind everybody, different OSes handle Unicode differently as well. Think of it as case insensitivity for the different Unicode ways of encoding the same glyph. For example U+00DC (LATIN CAPITAL LETTER U WITH DIAERESIS) vs U+0055 (LATIN CAPITAL LETTER U) and U+0308 (COMBINING DIAERESIS). Apple's HFS+ file system always decomposes file names to ensure consistent matching. Other OSes, not so much.

Aug 17 2015, 6:57 PM
alexr added a comment to D12029: [lld] LinkDriver, lld-link: introduce shim..

Saleem's original referenced proposal sounds to me a lot more like the original plan for lld's driver that was removed.

Aug 17 2015, 5:33 PM

Jul 29 2015

alexr accepted D11279: Initial patch for PS4 toolchain.

LGTM with the comment rewrite that Eric asked for.

Jul 29 2015, 6:03 PM

Jul 15 2015

alexr added a comment to D11207: Enable recognition of __declspec for PS4.

LGTM

Jul 15 2015, 10:41 AM

Mar 27 2015

alexr added a comment to D498: Optimize double storing by memset; memcpy.

This only handles overlap at the start of the memset. Does it make sense to handle other overlaps?

Mar 27 2015, 2:26 PM

Feb 17 2015

alexr added a comment to D7695: [Mach-O] Dtrace Support Part 1: User SDT provider handling..

DTrace exists for ELF as well. Can some of this be moved to support that?

Feb 17 2015, 8:07 AM · lld

Feb 10 2015

alexr updated the diff for D7296: Add memory variant of vcvtps2ph..
  • Try storing only 64 bits.
  • Support f64 as well as i64. Add more tests.
Feb 10 2015, 4:09 PM

Feb 5 2015

alexr added a comment to D7199: Make the byte-shift SSE intrinsics emit vector shuffles which we know the backend can handle..

Please note that the original patch was developed by Andrea when you land it.

Feb 5 2015, 7:29 AM

Feb 4 2015

alexr updated the diff for D7296: Add memory variant of vcvtps2ph..

Try storing only 64 bits.

Feb 4 2015, 6:38 PM
alexr accepted D7298: Add test to clang-exception-flags.cpp.
Feb 4 2015, 2:36 PM
alexr awarded D7298: Add test to clang-exception-flags.cpp a Orange Medal token.
Feb 4 2015, 2:35 PM

Feb 2 2015

alexr committed rL227897: Revert part of r227437 as it was unnecessary. Thanks to echristo for.
Revert part of r227437 as it was unnecessary. Thanks to echristo for
Feb 2 2015, 4:00 PM

Jan 30 2015

alexr updated the diff for D7296: Add memory variant of vcvtps2ph..

Also add the xmm version.

Jan 30 2015, 8:41 AM
alexr retitled D7296: Add memory variant of vcvtps2ph. from to Add memory variant of vcvtps2ph..
Jan 30 2015, 8:12 AM

Jan 29 2015

alexr committed rL227446: Make the test actually test what it's supposed to test. Add a test for the from….
Make the test actually test what it's supposed to test. Add a test for the from…
Jan 29 2015, 7:21 AM
alexr committed rL227437: Cleanup a few tests on sse4a machines and FileCheckize along the way..
Cleanup a few tests on sse4a machines and FileCheckize along the way.
Jan 29 2015, 5:33 AM

Jan 28 2015

alexr committed rL227340: Assume code ownership for the PS4 to ensure patches get reviewed, per the….
Assume code ownership for the PS4 to ensure patches get reviewed, per the…
Jan 28 2015, 10:35 AM
alexr committed rL227336: Enable pragma comment processing for PS4. Original patch by Yunzhong Gao!.
Enable pragma comment processing for PS4. Original patch by Yunzhong Gao!
Jan 28 2015, 10:28 AM

Jan 27 2015

alexr committed rL227223: Check wchar_t type on PS4..
Check wchar_t type on PS4.
Jan 27 2015, 10:44 AM
alexr committed rL227194: Begin to teach clang about the PS4..
Begin to teach clang about the PS4.
Jan 27 2015, 6:49 AM

Jan 26 2015

alexr committed rL227116: Use a different encoding for debugtrap on PS4..
Use a different encoding for debugtrap on PS4.
Jan 26 2015, 11:11 AM
alexr committed rL227105: Remove trailing whitespace. NFC ®.
Remove trailing whitespace. NFC ®
Jan 26 2015, 10:03 AM
alexr committed rL227103: Remove trailing whitespace..
Remove trailing whitespace.
Jan 26 2015, 9:37 AM
alexr committed rL227091: [MC] The PS4's ELF OSABI value is the same as FreeBSD..
[MC] The PS4's ELF OSABI value is the same as FreeBSD.
Jan 26 2015, 7:44 AM
alexr committed rL227090: Teach the autoconf machinery about the PS4 triple..
Teach the autoconf machinery about the PS4 triple.
Jan 26 2015, 7:26 AM

Jan 25 2015

alexr committed rL227060: Add the triple for the Sony Playstation®4..
Add the triple for the Sony Playstation®4.
Jan 25 2015, 2:48 PM

Oct 9 2014

alexr added a comment to D5701: [X86] Memory folding for commutative instructions..

Macro testcase:

Oct 9 2014, 10:12 AM

Sep 11 2014

alexr added a comment to D5316: [Power] Add a new feature flag for support of the sync instruction.

601 and others had sync.

Sep 11 2014, 4:03 PM

Apr 29 2014

alexr closed D3090: Modules - fix exclude header with umbrella directory.
Apr 29 2014, 4:30 PM
alexr accepted D3090: Modules - fix exclude header with umbrella directory.

This was r206342.

Apr 29 2014, 4:30 PM