This is an archive of the discontinued LLVM Phabricator instance.

[libcxx] [ci] Add a i386 Windows configuration to CI
ClosedPublic

Authored by mstorsjo on May 5 2022, 12:22 AM.

Details

Summary

Adding a mingw based config is easy in the current CI environment
(where we can just choose the different target by calling
i686-w64-mingw32-clang), while adding a clang-cl based config would
require setting up different environment variables pointing to the
i386 library directory.

Just adding one config (DLL) instead of exhaustively testing both
(DLL and static) as very few tests would differ in practice, to keep
the CI load reasonable.

A couple tests still fail in this config - they are fixed by D124989
and D124990.

Diff Detail

Event Timeline

mstorsjo created this revision.May 5 2022, 12:22 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 5 2022, 12:22 AM
mstorsjo requested review of this revision.May 5 2022, 12:22 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 5 2022, 12:22 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
ldionne accepted this revision.May 5 2022, 8:26 AM

LGTM with green CI

This revision is now accepted and ready to land.May 5 2022, 8:26 AM
mstorsjo updated this revision to Diff 427428.May 5 2022, 1:22 PM

Rebased after landing fixes for the tests; the new CI config should now pass.

This revision was automatically updated to reflect the committed changes.